1159192 - Please deploy 0.16.0 loop-client to STAGE

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Mark Banner (:standard8)]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla/loop-client/releases

COMPARISONS
https://github.com/mozilla/loop-client/compare/0.13.5...0.14.0
https://github.com/mozilla/loop-client/compare/0.14.0...0.15.0
https://github.com/mozilla/loop-client/compare/0.15.0...0.16.0

TAGS
https://github.com/mozilla/loop-client/releases/tag/0.16.0
https://github.com/mozilla/loop-client/commit/99108a80bca899ccc33f2231e8c8b5c58fa4a83f

CHANGELOG
0.16.0 (2015-04-28)
-------------------

- Bug 1141128 - add a margin of 10px to the left side of the remote video stream in the Loop standalone client
- Bug 1141133 - Implement encrypt/decrypt of context information ready for Loop's context in conversation work
- Bug 1137843 - Loop client should not try to leave room that it fails to join
- Bug 1146929 - Remove support for the old style call hash based urls from the Loop standalone UI
- Bug 1114563 - Show the room name before the user enters the room
- Bug 1132301 - Part 3 - hide the Loop dropdowns when the content window loses focus, so mouseLeave workarounds can be removed
- Bug 1105490 - Remove old ToS generation code from Loop Standalone
- Bug 1147609 - Make Loop's standalone UI work with roomName as an unencrypted parameter or as an encrypted part of context
- Bug 1146834 - use Uint8Array's subarray when slice is not available in Loop content pages
- Bug 1150273 - Use eslint for the react files for Loop
- Bug 1152296 - Move roomStore.js from shared code to desktop specific code for Loop
- Bug 1136797 - For Loop standalone rename the brand website url to download firefox url and update the default
- Bug 1132301 - Part 3 hide the Loop dropdowns when the content window loses focus, so mouseLeave workarounds can be removed
- Bug 1142522 - Part 1 Share utils and crypto content modules with chrome as well
- Bug 1142522 - Part 2 Hook up encryption for room contexts in guest mode
- Bug 1153418 - Fix an issue on Loop's standalone where the remote and video alignment during screenshare is 10px out
- Bug 1142588 - Implement context in conversations display for Loop's standalone UI
- Bug 1155036 - Standalone display is unusable at 640x500
- Bug 1154862 - Add forgotten param to VideoDimensionsChanged action
- Bug 1154868 - Log exceptions in bufferedUpdateVideo callbacks
- Bug 1155561 - ignore body clicks on dropdown menu buttons, to make dropdowns in Loop windows toggle properly
- Bug 1079697 - Remove obsolete jshint messages in Loop code
- Bug 1132222 - Add more metrics reporting to the Loop standalone UI
- Bug 1156201 - Reset the video dimensions cache when in initial room states to avoid issues with not correctly displaying video streams when a room is re-entered
- Bug 1137813 - Add room connection status logging
- Bug 1158800 - Don't show errors for context in conversations on the standalone UI as they may force the user into an unnecessary re-obtaining of the URL
- Update L10n to latest versions

Config changes:
- Added loop.config.downloadFirefoxUrl
- Removed loop.config.brandWebsiteUrl

Comment 1

[Mark Banner (:standard8)]

As mentioned in comment 0. Configuration changes are required for this release:

Remove loop.config.brandWebsiteUrl

Add loop.config.downloadFirefoxUrl with value "https://www.mozilla.org/firefox/new/?scene=2&utm_source=hello.firefox.com&utm_medium=referral&utm_campaign=non-webrtc-browser\#download-fx"

Comment 2

[Bob Micheletto [:bobm]]

Taking this bug as the deployment is time sensitive.

Comment 3

[Bob Micheletto [:bobm]]

This has been deployed to Stage.  Closing bug.

Comment 4

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
SUMMARY
------------------

Placed several calls back and forth between Nightly and DevEd(Aurora) including some tab and window sharing.

Verifying stage.

Mark, a few things...

[1]. Did we need to get this going: 
Bug 1124854 - Can we redirect hello.firefox.com to www.mozilla.org/firefox/hello/
Would this just be a config change to prod?  If so, I'll let bobm know.

[2]. Tab & Window sharing verified in both Nightly and Stage though tab sharing silently 'fails' when there's only 1 tab present.  I'm thinking we should at least notify the user they need a 2nd tab for tab sharing to work or allow them to share when only 1 tab is present.  Is there a bug for that?  If not I can file one.

[3]. Also, all unit tests pass, but I have to add this extra line to work with a github clone:

app.use('/test', express.static(__dirname + '/test'));
after:
https://github.com/mozilla/loop-client/blob/master/server.js#L57
to get them to run in browser.

Would it be possible to get npm test or make test working?

------------------
STAGE VALIDATION
------------------

STAGE STACK
CHANGELOG on stage stack says "0.16.0"
other than that there's currently no way to verify deployment version.
(note: VERSION.txt has been removed)

PROCESSES RUNNING:
stackdriver, nginx, python, circus, heka  

------------------
QUICK CHECKS - STAGE
------------------

unit tests on localhost with 0.16.0 tag - OK!

https://call.stage.mozaws.net/:
Welcome to the Firefox Hello web client.


Legal & ToS with FTU - OK!


$ curl -I https://call.stage.mozaws.net
HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Length: 7233
Content-Security-Policy: frame-ancestors 'self'
Content-Type: text/html
Date: Thu, 30 Apr 2015 02:28:16 GMT
ETag: "553f6072-1c41"
Last-Modified: Tue, 28 Apr 2015 10:26:58 GMT
Vary: Accept-Encoding
X-Frame-Options: SAMEORIGIN
X-Token-Match: 1
Connection: keep-alive



https://loop.stage.mozaws.net/:

{
  "name": "mozilla-loop-server",
  "description": "The Mozilla Loop (WebRTC App) server",
  "version": "0.17.7",
  "homepage": "https://github.com/mozilla-services/loop-server/",
  "endpoint": "https://loop.stage.mozaws.net",
  "fakeTokBox": false,
  "fxaOAuth": true,
  "i18n": {
    "defaultLang": "en-US",
    "lang": "en-US"
  }
}

Comment 5

[Mark Banner (:standard8)]

(In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #4)
> [1]. Did we need to get this going: 
> Bug 1124854 - Can we redirect hello.firefox.com to
> www.mozilla.org/firefox/hello/
> Would this just be a config change to prod?  If so, I'll let bobm know.

This is more than a config change and needs testing on staging. Given the priority of the other things we need in this release, I think this can wait until the next one. I must admit I forgot about it for this release.

> [2]. Tab & Window sharing verified in both Nightly and Stage though tab
> sharing silently 'fails' when there's only 1 tab present.  I'm thinking we
> should at least notify the user they need a 2nd tab for tab sharing to work
> or allow them to share when only 1 tab is present.  Is there a bug for that?
> If not I can file one.

That will most likely be bug 1137634 - its e10s only and doesn't affect release users at the moment. We're looking at fixing it in the next couple of cycles. If its not that, please file a bug.

> [3]. Also, all unit tests pass, but I have to add this extra line to work
> with a github clone:
> 
> app.use('/test', express.static(__dirname + '/test'));
> after:
> https://github.com/mozilla/loop-client/blob/master/server.js#L57
> to get them to run in browser.
> 
> Would it be possible to get npm test or make test working?

I'll take a look and see if its easy to do in a short time, we might already have a bug about this. Note that we're running these tests before the files are extracted from mozilla-central so the only real issue might be the files are extracted wrongly.

Comment 6

[Richard Pappalardo [:rpapa][:rpappalardo]]

(In reply to Mark Banner (:standard8) from comment #5)
> (In reply to Richard Pappalardo [:rpapa][:rpappalardo] from comment #4)
> > [1]. Did we need to get this going: 
> > Bug 1124854 - Can we redirect hello.firefox.com to
> > www.mozilla.org/firefox/hello/
> > Would this just be a config change to prod?  If so, I'll let bobm know.
> 
> This is more than a config change and needs testing on staging. Given the
> priority of the other things we need in this release, I think this can wait
> until the next one. I must admit I forgot about it for this release.
No worries, we'll remind each other for the next release.
> 
> > [2]. Tab & Window sharing verified in both Nightly and Stage though tab
> > sharing silently 'fails' when there's only 1 tab present.  I'm thinking we
> > should at least notify the user they need a 2nd tab for tab sharing to work
> > or allow them to share when only 1 tab is present.  Is there a bug for that?
> > If not I can file one.
> 
> That will most likely be bug 1137634 - its e10s only and doesn't affect
> release users at the moment. We're looking at fixing it in the next couple
> of cycles. If its not that, please file a bug.

Yes, it looks like that.  I'll keep an eye out going forward to see if it gets resolved.

> > [3]. Also, all unit tests pass, but I have to add this extra line to work
> > with a github clone:
> > 
> > app.use('/test', express.static(__dirname + '/test'));
> > after:
> > https://github.com/mozilla/loop-client/blob/master/server.js#L57
> > to get them to run in browser.
> > 
> > Would it be possible to get npm test or make test working?
> 
> I'll take a look and see if its easy to do in a short time, we might already
> have a bug about this. Note that we're running these tests before the files
> are extracted from mozilla-central so the only real issue might be the files
> are extracted wrongly.
OK, great.  thank you!