1159231 - Remove old firefox/os page template

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

When all locales are translated and on the new firefox/os template design, we should remove the old template from the bedrock repo.

Need to check with flod to verify when this is ok to do.

Comment 1

[Francesco Lodolo [:flod]]

One more thing to fix: right not the template activation is broken.

Example: https://www.mozilla.org/pl/firefox/os/

firefox/os/index-new.lang is currently not activated, I should get redirected to another locale based on accept languages, but I'm not. I think we're still using the old template to establish if the template is active or not.

Comment 2

[Francesco Lodolo [:flod]]

Before the logic to chose between old and new template was in views.py
https://github.com/mozilla/bedrock/commit/5a12218ab5d595c9a75867ddb9506af46be179db#diff-784e0d4de42af29595e70315a6be5337L245

Now it's enough to have firefox/os/devices.lang enabled to get the entire page enabled, I suppose because of these inclusions
https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/os/ver/1.1.html#L7

Comment 3

[Francesco Lodolo [:flod]]

List of affected locales (enabled on the old page, not in new one): bn-BD, hr, mk, son, zh-CN.

Comment 4

[Malena Andrade [:malenita]]

Attachment: https://github.com/mozilla/bedrock/pull/2995

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/47af64648fa0cbf382c5f97db0496584dc02c022
Bug 1159231- Remove old firefox/os page template

https://github.com/mozilla/bedrock/commit/5d91d470a8bf50a0643bb7d15929b586cdf943f1
Merge pull request #2995 from malena/bug-1159231-remove-old-fxos-template

Bug 1159231- Remove old firefox/os page template

Comment 6

[Francesco Lodolo [:flod]]

PR fixed a while ago, lang file removed in r142512.