1159232 - Avoid use of template string in GeckoDriver#sendAsync

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Andreas Tolfsen ❲:ato❳]

GeckoDriver#sendAsync is called frequently and we know there are performance drawbacks to using template strings.

This means we should only use them in infrequently called methods or where it's otherwise inconvenient to use plain strings.

https://dxr.mozilla.org/mozilla-central/source/testing/marionette/driver.js?from=marionette/driver.js#325

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: bz://1159232/ato

/r/7741 - Bug 1159232: Avoid use of template string in GeckoDriver#sendAsync

Pull down this commit:

hg pull -r 0f73cedd438590b6489fd6e8df34c9ae27e22e5c https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b383534bbdfd

Comment 3

[David Burns :automatedtester]

Comment on attachment 8598630 [details]
MozReview Request: bz://1159232/ato

https://reviewboard.mozilla.org/r/7739/#review6585

Ship It!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e14df688e369

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e14df688e369

Comment 7

[Andreas Tolfsen ❲:ato❳]

Attachment: MozReview Request: Bug 1159232: Avoid use of template string in GeckoDriver#sendAsync