Build error: MSVC_ENABLE_PGO = True is not permitted to be used in mailnews/intl/moz.build

RESOLVED FIXED in Thunderbird 40.0

Status

MailNews Core
Build Config
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

unspecified
Thunderbird 40.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently mailnews is busted:


Reticulating splines...
Traceback (most recent call last):
  File "./config.status", line 1014, in <module>
    config_status(**args)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/config_status.py", line 149, in config_status
    summary = the_backend.consume(definitions)
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/backend/base.py", line 180, in consume
    for obj in objs:
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/frontend/emitter.py", line 141, in emit
    for out in output:
  File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/frontend/reader.py", line 975, in read_mozbuild
    raise bre
mozbuild.frontend.reader.BuildReaderError: 
==============================
ERROR PROCESSING MOZBUILD FILE
==============================

The error occurred while processing the following file:

    /builds/slave/c-cen-t-lnx/build/mailnews/intl/moz.build

The error was triggered on line 33 of this file:

    MSVC_ENABLE_PGO = True

The underlying problem is an attempt to write a reserved UPPERCASE variable that does not exist.

The variable write causing the error is:

    MSVC_ENABLE_PGO

Please change the file to not use this variable.

For reference, the set of valid variables is:

A11Y_MANIFESTS, ANDROID_ECLIPSE_PROJECT_TARGETS, ANDROID_GENERATED_RESFILES, ANDROID_INSTRUMENTATION_MANIFESTS, ANDROID_RES_DIRS, BROWSER_CHROME_MANIFESTS, CFLAGS, CMFLAGS, CMMFLAGS, CONFIGURE_DEFINE_FILES, CONFIGURE_SUBST_FILES, CPP_UNIT_TESTS, CRASHTEST_MANIFESTS, CXXFLAGS, DEFFILE, DEFINES, DELAYLOAD_DLLS, DIRS, DISABLE_STL_WRAPPING, DIST_FILES, DIST_SUBDIR, EXPORTS, EXTRA_COMPONENTS, EXTRA_DSO_LDOPTS, EXTRA_JS_MODULES, EXTRA_PP_COMPONENTS, EXTRA_PP_JS_MODULES, FAIL_ON_WARNINGS, FILES_PER_UNIFIED_FILE, FINAL_LIBRARY, FINAL_TARGET, FINAL_TARGET_FILES, FORCE_SHARED_LIB, FORCE_STATIC_LIB, GENERATED_EVENTS_WEBIDL_FILES, GENERATED_FILES, GENERATED_INCLUDES, GENERATED_SOURCES, GENERATED_UNIFIED_SOURCES, GENERATED_WEBIDL_FILES, GYP_DIRS, HAS_MISC_RULE, HOST_LIBRARY_NAME, HOST_OS_LIBS, HOST_PROGRAM, HOST_SIMPLE_PROGRAMS, HOST_SOURCES, HOST_USE_LIBS, IPDL_SOURCES, IS_COMPONENT, IS_FRAMEWORK, JAR_MANIFESTS, JAVA_JAR_TARGETS, JETPACK_ADDON_MANIFESTS, JETPACK_PACKAGE_MANIFESTS, JS_PREFERENCE_FILES, LDFLAGS, LD_VERSION_SCRIPT, LIBRARY_DEFINES, LIBRARY_NAME, LOCAL_INCLUDES, METRO_CHROME_MANIFESTS, MOCHITEST_CHROME_MANIFESTS, MOCHITEST_MANIFESTS, MOCHITEST_WEBAPPRT_CHROME_MANIFESTS, MOCHITEST_WEBAPPRT_CONTENT_MANIFESTS, NO_DIST_INSTALL, NO_JS_MANIFEST, NO_PGO, NO_VISIBILITY_FLAGS, OS_LIBS, PREPROCESSED_TEST_WEBIDL_FILES, PREPROCESSED_WEBIDL_FILES, PROGRAM, PYTHON_UNIT_TESTS, RCFILE, RCINCLUDE, REFTEST_MANIFESTS, RESFILE, RESOURCE_FILES, SDK_LIBRARY, SHARED_LIBRARY_NAME, SIMPLE_PROGRAMS, SONAME, SOURCES, SPHINX_PYTHON_PACKAGE_DIRS, SPHINX_TREES, STATIC_LIBRARY_NAME, TESTING_JS_MODULES, TEST_DIRS, TEST_HARNESS_FILES, TEST_WEBIDL_FILES, UNIFIED_SOURCES, USE_EXTENSION_MANIFEST, USE_LIBS, USE_STATIC_LIBS, WEBIDL_EXAMPLE_INTERFACES, WEBIDL_FILES, WEBRTC_SIGNALLING_TEST_MANIFESTS, WIN32_EXE_LDFLAGS, XPCSHELL_TESTS_MANIFESTS, XPIDL_MODULE, XPIDL_SOURCES, XPI_NAME

*** Fix above errors and then restart with\
               "make -f client.mk build"
make[1]: *** [configure] Error 1
make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build'

I suspect TB is also busted.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Updated

2 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Updated

2 years ago
Depends on: 1157835
(Assignee)

Comment 9

2 years ago
Created attachment 8598650 [details] [diff] [review]
proposed patch (v1)
Attachment #8598650 - Flags: review?(Pidgeot18)
Sorry for the bustage! That patch looks good to me.

Comment 11

2 years ago
Comment on attachment 8598650 [details] [diff] [review]
proposed patch (v1)

Review of attachment 8598650 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing this review in the interest of unbusting the tree...
Attachment #8598650 - Flags: review?(Pidgeot18) → review+

Comment 12

2 years ago
https://hg.mozilla.org/comm-central/rev/c556e330585b

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
This patch seems to be missing from current comm-release (https://hg.mozilla.org/releases/comm-release/file/default/mailnews/intl/moz.build), hence builds fail here with the same error (tested on Linux and Windows).

https://hg.mozilla.org/releases/comm-release: 3b2a878de79bef8002ec52776362394d9d6f6e8b
https://hg.mozilla.org/releases/mozilla-release: 9879336c72be993ea9e57af2d91c92c90cc95806

07:43:00 Traceback (most recent call last):
07:43:00   File "./config.status", line 1021, in <module>
07:43:00     config_status(**args)
07:43:00   File "/home/mozilla/jenkins/workspace/seamonkey-release_linux64/mozilla/python/mozbuild/mozbuild/config_status.py", line 149, in config_status
07:43:00     summary = the_backend.consume(definitions)
07:43:00   File "/home/mozilla/jenkins/workspace/seamonkey-release_linux64/mozilla/python/mozbuild/mozbuild/backend/base.py", line 180, in consume
07:43:00     for obj in objs:
07:43:00   File "/home/mozilla/jenkins/workspace/seamonkey-release_linux64/mozilla/python/mozbuild/mozbuild/frontend/emitter.py", line 142, in emit
07:43:00     for out in output:
07:43:00   File "/home/mozilla/jenkins/workspace/seamonkey-release_linux64/mozilla/python/mozbuild/mozbuild/frontend/reader.py", line 977, in read_mozbuild
07:43:00     raise bre
07:43:00 mozbuild.frontend.reader.BuildReaderError: 
07:43:00 ==============================
07:43:00 ERROR PROCESSING MOZBUILD FILE
07:43:00 ==============================
07:43:00 
07:43:00 The error occurred while processing the following file:
07:43:00 
07:43:00     /home/mozilla/jenkins/workspace/seamonkey-release_linux64/mailnews/intl/moz.build
07:43:00 
07:43:00 The error was triggered on line 33 of this file:
07:43:00 
07:43:00     MSVC_ENABLE_PGO = True
07:43:00 
07:43:00 The underlying problem is an attempt to write a reserved UPPERCASE variable that does not exist.
07:43:00 
07:43:00 The variable write causing the error is:
07:43:00 
07:43:00     MSVC_ENABLE_PGO
07:43:00 
07:43:00 Please change the file to not use this variable.
Severity: normal → blocker
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 30

2 years ago
Comment on attachment 8598650 [details] [diff] [review]
proposed patch (v1)

[Approval Request Comment]
see comment 29. Is SM releasing 39 or why did this come up?
Attachment #8598650 - Flags: approval-comm-release?

Updated

2 years ago
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago2 years ago
Resolution: --- → FIXED
(In reply to aleth [:aleth] from comment #30)
> Is SM releasing 39 or why did this come up?

Nope - this did come up while I tried to do my own builds out of comm-release.

Comment 32

2 years ago
(In reply to Adrian Kalla [:adriank] from comment #31)
> (In reply to aleth [:aleth] from comment #30)
> > Is SM releasing 39 or why did this come up?
> 
> Nope - this did come up while I tried to do my own builds out of
> comm-release.

You probably know this already, but just in case I should point out that building off c-r won't give you a TB version that was ever released, as TB releases are based off the ESR branches (31, 38, 45...).
(Assignee)

Comment 33

2 years ago
(In reply to aleth [:aleth] from comment #32)
> (In reply to Adrian Kalla [:adriank] from comment #31)
> > (In reply to aleth [:aleth] from comment #30)
> > > Is SM releasing 39 or why did this come up?
> > 
> > Nope - this did come up while I tried to do my own builds out of
> > comm-release.
> 
> You probably know this already, but just in case I should point out that
> building off c-r won't give you a TB version that was ever released, as TB
> releases are based off the ESR branches (31, 38, 45...).

Yes, this needs to be pushed to c-r to fix SeaMonkey release.
(In reply to Edmund Wong (:ewong) from comment #33)
> Yes, this needs to be pushed to c-r to fix SeaMonkey release.

Never mind: Looks like I was building after the mozilla-beta to mozilla-release merge, but before the comm-beta to comm-release merge - now the problem does not happen anymore.

Updated

2 years ago
Attachment #8598650 - Flags: approval-comm-release?
You need to log in before you can comment on or make changes to this bug.