1159303 - Reduce noise due to sort operations warnings

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

The current message is too long and very annoying when looking through test logs, I think we can shorten them without loosing too much value, regardless any serious Storage developer should either use PRLog or set MOZ_STORAGE_SORTWARNING_SQL_DUMP

I'd like it to be a 1-liner, as far as possible.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1

This is a bit less verbose than what we have.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8598731 [details] [diff] [review]
patch v1

Review of attachment 8598731 [details] [diff] [review]:
-----------------------------------------------------------------

::: storage/src/mozStoragePrivateHelpers.cpp
@@ +97,5 @@
>      return;
>  
> +  nsAutoCString message("Suboptimal indexes for the SQL statement ");
> +#ifdef MOZ_STORAGE_SORTWARNING_SQL_DUMP
> +  message.AppendLiteral("`");

Nit: Append('`')

@@ +106,5 @@
>  #else
>    nsPrintfCString address("0x%p", aStatement);
>    message.Append(address);
>  #endif
> +  message.Append("' (http://mzl.la/1FuID0j).");

Nit: Don't need the "'" any more

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ops sorry, I didn't notice ', I need better eyeglasses!
and while there, it should be an AppendLiteral...

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2696c3d2ee51

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2696c3d2ee51