Closed Bug 1159347 Opened 5 years ago Closed 5 years ago

Make BaseProxyHandler::getPropertyDescriptor not-pure virtual

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(1 file)

This proxy trap is not one of the ES6 specified operations and can't be trivially desugared.
Attachment #8598771 - Flags: review?(efaustbmo)
&desc should be desc, I forgot to refresh.
Comment on attachment 8598771 [details] [diff] [review]
Make BaseProxyHandler::getPropertyDescriptor not-pure virtual

Review of attachment 8598771 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: js/src/proxy/DeadObjectProxy.h
@@ -37,5 @@
>      virtual bool call(JSContext* cx, HandleObject proxy, const CallArgs& args) const override;
>      virtual bool construct(JSContext* cx, HandleObject proxy, const CallArgs& args) const override;
>  
>      /* SpiderMonkey extensions. */
> -    virtual bool getPropertyDescriptor(JSContext* cx, HandleObject wrapper, HandleId id,

please add a comment here that we intend to fall back on BaseProxyHandler::getPropertyDescriptor, which will throw in DeadObjectProxy::getOwnPropertyDescriptor
Attachment #8598771 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/81f4948015ae
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.