1159347 - Make BaseProxyHandler::getPropertyDescriptor not-pure virtual

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

Attachment: Make BaseProxyHandler::getPropertyDescriptor not-pure virtual

This proxy trap is not one of the ES6 specified operations and can't be trivially desugared.

Comment 1

[Tom S [:evilpie]]

&desc should be desc, I forgot to refresh.

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8598771 [details] [diff] [review]
Make BaseProxyHandler::getPropertyDescriptor not-pure virtual

Review of attachment 8598771 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: js/src/proxy/DeadObjectProxy.h
@@ -37,5 @@
>      virtual bool call(JSContext* cx, HandleObject proxy, const CallArgs& args) const override;
>      virtual bool construct(JSContext* cx, HandleObject proxy, const CallArgs& args) const override;
>  
>      /* SpiderMonkey extensions. */
> -    virtual bool getPropertyDescriptor(JSContext* cx, HandleObject wrapper, HandleId id,

please add a comment here that we intend to fall back on BaseProxyHandler::getPropertyDescriptor, which will throw in DeadObjectProxy::getOwnPropertyDescriptor

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81f4948015ae

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/81f4948015ae