eliminate NS_COMFALSE

VERIFIED FIXED in M15

Status

()

Core
DOM: Core & HTML
P3
normal
VERIFIED FIXED
19 years ago
10 months ago

People

(Reporter: Warren Harris, Assigned: vidur (gone))

Tracking

({helpwanted})

Trunk
All
Other
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
We should eliminate the NS_COMFALSE madness once and for all. Here's a list of
offending uses in your module -- please pass the bug along if there's someone
else who should deal with it.

      dom/src/base/nsJSEnvironment.cpp:
            View change log or Blame annotations
            line 316
      dom/src/base/nsJSUtils.cpp:
            View change log or Blame annotations
            line 383
      dom/src/build/nsScriptNameSpaceManager.cpp:
            View change log or Blame annotations
            line 124
      dom/src/events/nsJSDOMEventListener.cpp:
            View change log or Blame annotations
            line 93

Updated

19 years ago
Blocks: 8929
Summary: eliminate NS_COMFALSE → [HELP WANTED] eliminate NS_COMFALSE
Target Milestone: M15

Comment 1

18 years ago
dom/src/build/nsScriptNameSpaceManager.cpp fixed, all instances of LookupName
check for a return result of NS_OK explicitly
(Assignee)

Comment 2

18 years ago
In an attempt to get my bug list in order again, marking all the bugs I have
currently as ASSIGNED.

Updated

18 years ago
Keywords: helpwanted

Updated

18 years ago
Summary: [HELP WANTED] eliminate NS_COMFALSE → eliminate NS_COMFALSE
All traces of NS_COMFALSE is removed from the DOM (mozilla/dom) code, marking
this FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 4

18 years ago
jst@netscape, or Warren Could anyone of you verify this one ?

Comment 5

18 years ago
The only files left in the source tree using NS_COMFALSE are:

./js/src/xpconnect/src/xpccomponents.cpp
./rdf/content/src/nsXULAttributes.cpp
./rdf/content/src/nsXULElement.cpp
./xpcom/appshell/eventloop/xp/nsIDispatchListener.idl
./xpcom/appshell/eventloop/xp/nsIEventLoop.idl
./xpcom/appshell/eventloop/xp/nsITranslateListener.idl
./xpcom/appshell/eventloop/photon/nsCPlatformBaseLoop.cpp
./xpcom/appshell/eventloop/windows/nsCBreathLoop.cpp
./xpcom/appshell/eventloop/windows/nsCPlatformBaseLoop.cpp
./xpcom/base/nsError.h
./xpcom/ds/nsHashtableEnumerator.cpp
./xpcom/ds/nsIEnumerator.idl
./layout/base/public/nsIFrameSelection.h
./layout/base/public/nsISelection.h
./layout/base/src/nsDocument.cpp
./layout/base/src/nsSelection.cpp
./layout/base/src/nsStyleSet.cpp
./layout/html/content/src/nsGenericHTMLElement.cpp
./layout/html/style/public/nsICSSStyleSheet.h
./layout/html/style/src/nsCSSLoader.cpp
./layout/html/style/src/nsCSSParser.cpp
./layout/html/style/src/nsCSSRules.cpp
./layout/html/style/src/nsCSSStyleSheet.cpp
./layout/html/style/src/nsHTMLAttributes.cpp
./layout/html/style/src/nsHTMLCSSStyleSheet.cpp
./layout/html/style/src/nsHTMLStyleSheet.cpp
./layout/xul/base/src/nsScrollbarFrame.cpp
./mailnews/db/msgdb/public/nsIDBChangeAnnouncer.idl
./mailnews/db/msgdb/src/nsMsgDatabase.cpp
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.