Closed Bug 1159454 Opened 9 years ago Closed 9 years ago

[Customizer] Perform JavaScript code validation for 'Script' tab in Edit Mode

Categories

(Firefox OS Graveyard :: Gaia::Customizer, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justindarc, Assigned: justindarc)

References

Details

(Whiteboard: [spark])

Attachments

(1 file)

We should show some sort of validation to the user after editing code in the 'Script' tab in Edit Mode. Need to investigate to see if its feasible to utilize JSHint for this.
Whiteboard: [spark]
Attached file pull-request (master)
Assignee: nobody → jdarcangelo
Attachment #8599602 - Flags: review?(drs)
Comment on attachment 8599602 [details] [review]
pull-request (master)

This is really cool. There are a lot of papercut issues still, such as editing the end of the textareas and not being able to see it due to autofilling, but it works well and I don't see any issues in the code.

We might also want to increase the timeout for validation. It feels a bit too fast right now and is more annoying than helpful. Maybe we could do something clever there like validate immediately whenever we get a carriage return, but wait 5 seconds for any other character. That's also a follow-up fix if we do it, though.
Attachment #8599602 - Flags: review?(drs) → review+
Thanks, Doug. I'll file follow-ups for the items you mentioned.

Landed on master:

https://github.com/fxos/customizer/commit/e33dbf602f424b5c6db2c21b5e81ccf1739325e6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: