1159455 - APZ debug logging format specifiers need cleanup

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The printf format specifiers fail to compile on some platforms.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Also removed \n from NS_WARNINGs and fixed APZES_LOG. Try push with these changes and all the debug logging enabled is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=7db7071a1c16

Comment 2

[Botond Ballo [:botond] [away until Oct 19]]

Comment on attachment 8598906 [details] [diff] [review]
Patch

Review of attachment 8598906 [details] [diff] [review]:
-----------------------------------------------------------------

I think we need to use the PRIuSIZE macro instead of "zu", see [1].

[1] https://dxr.mozilla.org/mozilla-central/source/mfbt/SizePrintfMacros.h

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8598906 [details] [diff] [review]
Patch

Makes sense, I'll update the patch. I'm wondering how it compiled successfully on windows though (in the try push).

Comment 4

[Botond Ballo [:botond] [away until Oct 19]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Makes sense, I'll update the patch. I'm wondering how it compiled
> successfully on windows though (in the try push).

MOZ_FORMAT_PRINTF expands to nothing on MSVC [1].

[1] http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nscore.h?rev=7e4e5e971d95#169

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b2fc3248afe4

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cca6dda7467

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0cca6dda7467