1159499 - First run of TB Daily with shipped-by-default Lightning warns about foreign addons

Status: RESOLVED WONTFIX

(Calendar :: General, defect)

Description

[aleth [:aleth]]

Attachment: Screen Shot.png

STR
Use an existing profile without Lightning installed.
Build TB40 with --enable-calendar and start it.
Result: Two scary-looking "Install add-on" tabs appear (see screenshot), one for Lightning and one for the Google Calendar provider.

Looking at the console, I see 

1430260116207	addons.xpi	WARN	Disabling foreign installed add-on {a62ef8ec-5fdc-40c2-873c-223b8a6925cc} in app-global
1430260116234	addons.xpi	WARN	Disabling foreign installed add-on {e2fda1a4-762b-4020-b5ad-a41df1933103} in app-global

and further down a bunch of 
2015-04-29 00:28:44: basic_code_modules.cc:88: INFO: No module at...
which may or may not be related.

Using a scratch profile ("mach run") these console error messages also appear.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Note that on nightly builds, Lightning is installed to bin/extensions/, hence you are getting the foreign install message and it should appear in the addons manager tab. For beta and release builds, its dropped into bin/distribution/extensions, which installs it into the profile, which will make it work.

This might be WORKSFORME since the behavior is different for beta builds.

Comment 2

[aleth [:aleth]]

That would be good news.

Comment 3

[Stefan Sitter [:ssitter]]

Philipp, why different behavior for nightly and release branches? In my opinion it should be the same. Otherwise it is not possible to verify that the feature is (still) working correctly until after it was merged from nightly to release branches.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to Stefan Sitter from comment #3)
> Philipp, why different behavior for nightly and release branches? In my
> opinion it should be the same. Otherwise it is not possible to verify that
> the feature is (still) working correctly until after it was merged from
> nightly to release branches.

For release we need to put the extension into bin/distribution/extensions because it should be installed into new profiles, and putting it into bin/extensions would also break binary signatures on mac.

For nightly, or at least for compiled builds, we need to put it into bin/extensions so that changes will reflect instantly on install, see bug 1075048.

If you find a switch between nightly and compiled builds, we could install into bin/extensions only for compiled builds.

Comment 5

[Geoff Lankow (:darktrojan)]

Lightning is now integrated into Thunderbird.