Closed Bug 1159502 Opened 5 years ago Closed 5 years ago
Don't block onload for multipart images
We were never supposed to be blocking onload for multipart images, but somewhere along the line a bug got introduced and we are blocking onload now. This causes two issues: - The throbber never stops for pages with multipart images. - We get tons of console spew about "Double block onload".
Here's the patch. I could swear I wrote this exact code in the past...
Attachment #8598973 - Flags: review?(tnikkel)
Attachment #8598973 - Flags: review?(tnikkel) → review+
Requesting checkin. For a try job, please see bug 1159409, for which I'm also requesting checkin.
Comment on attachment 8598973 [details] [diff] [review] Don't block onload for multipart images Approval Request Comment [Feature/regressing bug #]: Not sure. [User impact if declined]: We never stop the loading throbber for pages containing MJPEG streams. [Describe test coverage new/current, TreeHerder]: On m-c. [Risks and why]: Low risk. [String/UUID change made/needed]: None.
I'm assuming from comment 0 that you mean that this affects at least 37+ but may go further back.
Florin, since we're not sure when this regressed, can your team take a look to see if this is broken in 37 and 38? It may be trivial, but I'd like us to know. Thanks!
Comment on attachment 8598973 [details] [diff] [review] Don't block onload for multipart images OK, surprisingly enough it turns out this isn't broken on Aurora...
You need to log in before you can comment on or make changes to this bug.