Closed Bug 1159627 Opened 5 years ago Closed 5 years ago

resource:///modules/dbViewWrapper.js, line 560: SyntaxError: unreachable code after return statement

Categories

(Thunderbird :: Folder and Message Lists, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 40.0

People

(Reporter: aleth, Assigned: aleth)

Details

Attachments

(1 file)

Happens on startup.
Attached patch typofix.diffSplinter Review
well, that was trivial...
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8599197 - Flags: review?(acelists)
Comment on attachment 8599197 [details] [diff] [review]
typofix.diff

Review of attachment 8599197 [details] [diff] [review]:
-----------------------------------------------------------------

:)

Nit: we use to put bug number in the commit message.
Attachment #8599197 - Flags: review?(acelists) → review+
Severity: normal → trivial
Component: General → Folder and Message Lists
OS: Unspecified → All
Hardware: Unspecified → All
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Is this error visible in the error console? If so, I think we should land it (and similar bugs) in TB 38
I have never seen such a message in error console. Either it is new (as in TODAY, so TB40) or aleth has some special setup :) Either way, I think it not a concern for TB38 as nobody (from devs) noticed such a warning since TB38 branched (and e.g. I have the console permamently open on trunk build).
It's a new warning as far as I know (https://hg.mozilla.org/mozilla-central/rev/02520ac48ee3), which would show up in the console, but isn't in TB38.
Yes, I updated my tree from yesterday's to today's and now these warnings are there. So it really shouldn't be relevant to TB40, it is new development on trunk.
You need to log in before you can comment on or make changes to this bug.