Closed Bug 1159657 Opened 9 years ago Closed 8 years ago

[Meta] remove utils.js and move all it's functionality to related modules

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED FIXED
Project Flags:
tracking-b2g backlog

People

(Reporter: eragonj, Assigned: gasolin)

References

Details

Attachments

(2 files)

[gaia] EragonJ:bug-1159657 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
Details | Review
[gaia] gasolin:issue-1159657-2 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
scottwu
: review+
Details | Review 
In Settings app, there are still so many places using global function exposed from utils.js and it's time to clean them up and integrate all of them inside SettingsUtils to make sure we won't pollute the global context.
Comment on attachment 8599212 [details] [review]
[gaia] EragonJ:bug-1159657 > mozilla-b2g:master

Arthur, this patch is trying to remove utils.js and move related functions into SettingsUtils, any feedback for this patch !?
Attachment #8599212 - Flags: feedback?(arthur.chen)
Comment on attachment 8599212 [details] [review]
[gaia] EragonJ:bug-1159657 > mozilla-b2g:master

Thanks for the patch. Instead of having a giant util modules I was thinking to break it into smaller modules categorized by their functions. That would save time required for loading. Does that make sense to you?
Attachment #8599212 - Flags: feedback?(arthur.chen)
take for track
Assignee: eragonj+moz → gasolin
Depends on: 1202945
tracking-b2g: --- → backlog
Depends on: 1228252
Depends on: 1228265
Depends on: 1228276
Depends on: 1229263
Summary: [Settings] remove utils.js and integrate API in SettingsUtils → [Meta] remove utils.js and integrate API in SettingsUtils
Summary: [Meta] remove utils.js and integrate API in SettingsUtils → [Meta] remove utils.js and move all it's functionality to related modules
Blocks: 1181023
Comment on attachment 8702833 [details] [review]
[gaia] gasolin:issue-1159657-2 > mozilla-b2g:master

The patch removed the last part of util.js
Attachment #8702833 - Flags: review?(scwwu)
Comment on attachment 8702833 [details] [review]
[gaia] gasolin:issue-1159657-2 > mozilla-b2g:master

Looks good! r+
Attachment #8702833 - Flags: review?(scwwu) → review+
merged https://github.com/mozilla-b2g/gaia/commit/0ebc05da499b96dac9eca7f4bd4008957a4013f5

thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 1242075
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: