Closed Bug 1159676 Opened 9 years ago Closed 9 years ago

mailnews/mime/jsmime/test/test_custom_headers.js | run_next_test 0 - TypeError: _gRunningTest is undefined at /builds/slave/test/build/tests/xpcshell/head.js:1435 (and other jsmime tests)

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 40.0

People

(Reporter: mkmelin, Assigned: hiro)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file, 1 obsolete file)

Would appear to be from bug 1150822, at least that fits the time frame...

https://treeherder.mozilla.org/logviewer.html#?job_id=17399&repo=comm-central

02:44:17 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property options.softMargin" {file: "/builds/slave/test/build/tests/xpcshell/tests/mailnews/mime/jsmime/test/head_xpcshell_glue.js -> resource:///modules/jsmime/jsmime.js" line: 2479}]"
02:44:17 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: ({}) is not extensible" {file: "/builds/slave/test/build/tests/xpcshell/head.js" line: 1391}]"
02:44:17 WARNING - TEST-UNEXPECTED-FAIL | mailnews/mime/jsmime/test/test_custom_headers.js | run_next_test 0 - TypeError: _gRunningTest is undefined at /builds/slave/test/build/tests/xpcshell/head.js:1435
02:44:17 INFO - _run_next_test@/builds/slave/test/build/tests/xpcshell/head.js:1435:7
02:44:17 INFO - do_execute_soon/<.run@/builds/slave/test/build/tests/xpcshell/head.js:653:9
02:44:17 INFO - _do_main@/builds/slave/test/build/tests/xpcshell/head.js:207:5
02:44:17 INFO - _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:513:5
02:44:17 INFO - @-e:1:1
02:44:17 INFO - exiting test
02:44:17 INFO - (xpcshell/head.js) | test run_next_test 0 finished (1)
02:44:17 INFO - exiting test
02:44:17 INFO - <<<<<<<
02:44:17 INFO - TEST-START | mailnews/mime/jsmime/test/test_header_emitter.js
02:44:18 WARNING - TEST-UNEXPECTED-FAIL | mailnews/mime/jsmime/test/test_header_emitter.js | xpcshell return code: 0
Magnus, I am so sorry for breaking comm-central.

I am preparing a patch now, will post the patch after confirmation of its validity.
Assignee: nobody → hiikezoe
Attached patch Fix (obsolete) — Splinter Review
After bug 1150822 test must be a function, but a Promise was passed to add_task in head_xpsehll_glue.js.
This patch creates an arrow function to avoid the issue.

Confirmed that the patch works fine locally.
Now I pushed it to try.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=622c4b35ed2c
Attachment #8599581 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8599581 [details] [diff] [review]
Fix

Review of attachment 8599581 [details] [diff] [review]:
-----------------------------------------------------------------

Wrong patch attached. 

r=mkmelin for https://hg.mozilla.org/try-comm-central/rev/87799c39d721 though!
Attachment #8599581 - Flags: review?(mkmelin+mozilla)
Attached patch FixSplinter Review
Sorry!
Attachment #8599581 - Attachment is obsolete: true
Attachment #8599702 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8599702 [details] [diff] [review]
Fix

Review of attachment 8599702 [details] [diff] [review]:
-----------------------------------------------------------------

No problem, thx for the fix! r=mkmelin
Attachment #8599702 - Flags: review?(mkmelin+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/ad5a0fd389f5
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in before you can comment on or make changes to this bug.