Closed
Bug 1159709
Opened 9 years ago
Closed 9 years ago
Cleanup class hierarchy of Gonk socket I/O classes
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(6 files)
15.72 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
5.52 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
10.00 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
9.03 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
10.25 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
5.49 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
The hierarchy of Gonk socket I/O classes is mostly inconsistent and confusing. It should be cleaned up to reflect actual socket features and capabilities. Below is a class diagram to illustrate the relationship.
> |SocketBase|
> ^
> |
> +------------------+
> | |
> |DataSocket| |ListenSocket|
> ^
> |
> +------------------------------+
> | |
> |ConnectionOrientedSocket| |BluetoothSocket|
> ^
> |
> +-----------------+
> | |
> |StreamSocket| |BluetoothDaemonConnection|
|StreamSocket| and |ListenSocket| serve as base classes for task-specific classes (RIL, NFC), but hopefully, they can be used on their own in the future. |ListenSocket| returns accepted connections in instances of |ConnectionOrientedSocket|.
|BluetoothSocket| is special. It supports listening and data transfers, but Bluedroid's interfaces are not fully POSIX compatible, so |BlutoothSocket| is currently only supported as |DataSocket|.
This bug is about establishing the outlined class hierarchy.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef2d5c06e335 I had to send some other bugs' patches as well that haven't landed on m-c yet.
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8599321 -
Flags: review?(kyle)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8599322 -
Flags: review?(kyle)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8599323 -
Flags: review?(kyle)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8599324 -
Flags: review?(kyle)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8599325 -
Flags: review?(kyle)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8599326 -
Flags: review?(kyle)
Assignee | ||
Comment 8•9 years ago
|
||
Patch [01] does some refactoring of |BluetoothDaemonConnection|. The other patches only move code around.
Updated•9 years ago
|
Attachment #8599321 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8599322 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8599323 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8599324 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8599325 -
Flags: review?(kyle) → review+
Updated•9 years ago
|
Attachment #8599326 -
Flags: review?(kyle) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/38d4b09aef8f https://hg.mozilla.org/integration/b2g-inbound/rev/895d14811245 https://hg.mozilla.org/integration/b2g-inbound/rev/0b3216e864ee https://hg.mozilla.org/integration/b2g-inbound/rev/56c59c4e989d https://hg.mozilla.org/integration/b2g-inbound/rev/651f34fe1c01 https://hg.mozilla.org/integration/b2g-inbound/rev/694eac9d36bb
Assignee | ||
Comment 10•9 years ago
|
||
Thanks a lot. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=694eac9d36bb
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/38d4b09aef8f https://hg.mozilla.org/mozilla-central/rev/895d14811245 https://hg.mozilla.org/mozilla-central/rev/0b3216e864ee https://hg.mozilla.org/mozilla-central/rev/56c59c4e989d https://hg.mozilla.org/mozilla-central/rev/651f34fe1c01 https://hg.mozilla.org/mozilla-central/rev/694eac9d36bb
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•