Closed
Bug 1159742
Opened 9 years ago
Closed 9 years ago
Eliminate the pref annotation from test_interfaces tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
This annotation is broken by design. The point of these tests is to test that we're exposing what we mean to be exposing. Right now any time the pref annotation is used they're just testing that the pref does in fact control the exposure... but not testing that the pref value is set correctly. Seems to me like we should be using platform+channel annotations to describe the thing we actually care about (i.e. where the API is exposed) and not worry about the mechanism (prefs, test functions, whatever).
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8599934 -
Flags: review?(jst)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Updated•9 years ago
|
Attachment #8599934 -
Flags: review?(jst) → review+
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/703c29db2fb2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•