Closed
Bug 1159779
Opened 9 years ago
Closed 9 years ago
mozilla::AutoTimelineMarker should delte copy and move ctors and assignment
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
708 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It should really stay where it is, we don't want to accidentally add duplicate starts/ends or something.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8599557 -
Flags: review?(bugs)
Comment 2•9 years ago
|
||
Comment on attachment 8599557 [details] [diff] [review] mozilla::AutoTimelineMarker shouldn't be copy-able So copy ctor and assignment operator, not move ctor
Attachment #8599557 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #2) > Comment on attachment 8599557 [details] [diff] [review] > mozilla::AutoTimelineMarker shouldn't be copy-able > > So copy ctor and assignment operator, not move ctor Yup. Implicit move constructor/assignment won't be generated by the compiler because there is a user defined destructor.
Assignee | ||
Comment 4•9 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a2b989811c6
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4620352fe92e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•