Closed Bug 1159779 Opened 5 years ago Closed 5 years ago

mozilla::AutoTimelineMarker should delte copy and move ctors and assignment

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file)

It should really stay where it is, we don't want to accidentally add duplicate starts/ends or something.
Comment on attachment 8599557 [details] [diff] [review]
mozilla::AutoTimelineMarker shouldn't be copy-able

So copy ctor and assignment operator, not move ctor
Attachment #8599557 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8599557 [details] [diff] [review]
> mozilla::AutoTimelineMarker shouldn't be copy-able
> 
> So copy ctor and assignment operator, not move ctor

Yup. Implicit move constructor/assignment won't be generated by the compiler because there is a user defined destructor.
https://hg.mozilla.org/mozilla-central/rev/4620352fe92e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.