Closed
Bug 1159793
Opened 9 years ago
Closed 9 years ago
Report actual error code to telemetry instead of 110
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox38 | --- | unaffected |
firefox38.0.5 | --- | unaffected |
firefox39 | --- | fixed |
firefox40 | --- | fixed |
firefox41 | --- | unaffected |
firefox-esr31 | --- | unaffected |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
Attachments
(1 file)
2.20 KB,
patch
|
spohl
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The UPDATE_CHECK_EXTENDED_ERROR_* codes are overridden by 110 which is BACKGROUNDCHECK_MULTIPLE_FAILURES
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8603138 -
Flags: review?(spohl.mozilla.bugs)
Updated•9 years ago
|
Attachment #8603138 -
Flags: review?(spohl.mozilla.bugs) → review+
Assignee | ||
Updated•9 years ago
|
status-firefox39:
--- → affected
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aadbe230abec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8603138 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: Telemetry for update orphaning project - Bug 1137447 [User impact if declined]: We won't be able to determine update check extended errors using telemetry [Describe test coverage new/current, TreeHerder]: Landed on m-c several days ago [Risks and why]: Little to none. The patch changes where the code is called. [String/UUID change made/needed]: None
Attachment #8603138 -
Flags: approval-mozilla-beta?
Comment 5•9 years ago
|
||
Vladan can you take a look at this to make sure that we don't need to change any telemetry probe descriptions? It looks like it's just changing an existing probe and I'd like to uplift it to 39.
Flags: needinfo?(vdjeric)
Assignee | ||
Comment 6•9 years ago
|
||
Liz, the telemetry histograms don't need to be changed for this. I'll leave it to you whether you still want Vladan's needinfo.
Flags: needinfo?(lhenry)
Comment 8•9 years ago
|
||
Comment on attachment 8603138 [details] [diff] [review] patch Approved for uplift to beta (39)
Flags: needinfo?(lhenry)
Attachment #8603138 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 9•9 years ago
|
||
Pushed to mozilla-beta https://hg.mozilla.org/releases/mozilla-beta/rev/8c2cf22f867e
status-firefox38:
--- → unaffected
status-firefox38.0.5:
--- → unaffected
status-firefox41:
--- → unaffected
status-firefox-esr31:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•