Closed
Bug 1159813
Opened 9 years ago
Closed 9 years ago
Make sure service worker tests clean up after themselves
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
3.53 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
This makes it possible to run the service workers tests using --run-until-failure, which will hopefully help with reproducing intermittent test failures.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8599410 -
Flags: review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: ServiceWorkers-v1
Updated•9 years ago
|
Attachment #8599410 -
Flags: review?(amarchesini) → review+
Comment 3•9 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4344c0378fe6 for failing like https://treeherder.mozilla.org/logviewer.html#?job_id=9430017&repo=mozilla-inbound. Wish I could tell you the platforms where it fails, but we've gotten so stupid cheap that we hardly run any tests at all on most platforms now. Android and Mulet consistently failed, as did Linux64 opt the one time we ran tests on you there. Other than that, it's anybody's (or rather, try: -p all -u all's) guess where else it fails.
Flags: needinfo?(ehsan)
Assignee | ||
Comment 4•9 years ago
|
||
This failure happened because with my change unregister() would no longer return a value, so sometimes the promise chain would resolve down to the SimpleTest.finish() call faster than unregister would finish its work, in which case the test would fail.
Flags: needinfo?(ehsan)
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57fc3025cf99
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•