Playraterate.js breaks live recordings

RESOLVED FIXED

Status

P1
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Trunk

Firefox Tracking Flags

(firefox40 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The new playback rate code that generates the options (0.5x 1x 1.5x 2x) assumes that every video is archived. When run on a live view it raises TypeError in jquery.
(Assignee)

Comment 1

3 years ago
Richard, when the javascript breaks, it prevents the commenting to work properly that's why it sends the comment to the wrong place and thus that error that Mike had. 

We need to land this and push this out to prod today.
Assignee: nobody → peterbe
Severity: normal → critical
Priority: -- → P1

Comment 3

3 years ago
Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/faf8948ac71646014699a52552e965bc436f37f2
fixes bug 1159820 - Playraterate.js breaks live recordings

https://github.com/mozilla/airmozilla/commit/6bce69ad4915e89576d20a84432ac8fe681a1a3c
Merge pull request #290 from peterbe/bug-1159820-playrateratejs-breaks-live-recordings

fixes bug 1159820 - Playraterate.js breaks live recordings

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.