1159858 - [Statusbar] Statusbar does not reflect system dialog theme

Status: RESOLVED DUPLICATE of bug 1227448

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Oliver Nelson [:oliverthor]]

Attachment: 2015-04-29-19-02-28.png

Description:
When a user unlocks their phone from display off and encounters a SIM Pin Unlock screen, they will observe that the homescreen is revealed along the status bar at the top of the screen, as the dialog does not overrun it.

Repro Steps:
1) Update a Flame to 20150429010205
2) Enable a SIM Pin in Settings
3) Enable/Disable Airplane Mode
4) Observe SIM Pin prompt

Actual:
SIM Pin prompt does not cover screen, homescreen is revealed showing wallpaper

Expected:
SIM Pin prompt runs to status bar, blacks out to cover homescreen


Environmental Variables:
-------------------------------------------------------

Device: Flame 3.0
Build ID: 20150429010205
Gaia: 6e35b0948c42a4398b8a5916015de167121683a1
Gecko: 1ad65cbeb2f4
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150429002501
Gaia: 1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gecko: d38ff4717f39
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150429001202
Gaia: 9fda4aec7f9495a27a335ccaf3b1a4dc9c4c6db0
Gecko: 38ab00c01159
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
-------------------------------------------------------

Issue DOES NOT REPRO on 2.0 for flame devices:
Results: Status Bar paints black and blocks homescreen when SIM Prompt is revealed
Device: Flame 2.0
BuildID: 20150429000200
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: b154e9aae020
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-------------------------------------------------------

Repro frequency: 5/5
See attached: 
screenshot

Comment 1

[Peter Bylenga [:PBylenga]]

NI on component owner to take a look.

Comment 2

[Hermes Cheng (inactive after July 27, 2015)]

Actually, it shows the background of the app below SIM PIN input dialog. I believe this bug has existed for a while, and just like bug 1155566 but at different components.

Arthur, could you take a look?

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Alive, could you help dispatch it? Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Uh, I think Statusbar needs to know SystemDialog is opened/closed to change the color theme. However this looks like a polish to me. Switch ni to Michael to track it. (And I hope this could happen after 1094759 because the logic changes there)

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:
Long standing polish bug. Shall we take care of this finally in 3.0?

Alberto, can you take this bug?

Comment 7

[Alberto Pastor [:albertopq]]

As per comment #4, should we wait for bug 1094759 first?

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Alberto Pastor [:albertopq] from comment #7)
> As per comment #4, should we wait for bug 1094759 first?

Yeah, sounds like you'll have to fix it twice if you don't.

Comment 9

[Gregor Wagner [:gwagner]]

Not a blocker but lets fix it.

Comment 10

[Alberto Pastor [:albertopq]]

Hey Eric, what's the visual expectation here? Should the the statusbar background be black (as in the attention screen). Should it be the same color than the dialog background? Should the rocketbar be visible?

Thanks!

Comment 11

[Eric Pang [:epang] UX]

(In reply to Alberto Pastor [:albertopq] from comment #10)
> Hey Eric, what's the visual expectation here? Should the the statusbar
> background be black (as in the attention screen). Should it be the same
> color than the dialog background? Should the rocketbar be visible?
> 
> Thanks!

Hey Alberto, if this is being accessed from the settings it should be the light status bar with the dark grey icons.  I think it makes sense to leave the rocket bar out since the user needs to decide to skip or enter a pin on this screen. thx

Comment 12

[Alberto Pastor [:albertopq]]

Then I don't understand this bug. If I'm getting your reply correctly, you want the statusbar to be shown from the background app. In that case, the statusbar should be shown with the wallpaper background if the SIM pin dialog is shown in top of the homescreen, shouldn't it?

At the other hand, the user can always skip by clicking the 'Skip' button, so setting the statusbar always black (or the dialog color) and removing the rocketbar could potentially be an option.

Could you please clarify what's the expected behavior for the homecreen? Thanks!

Comment 13

[Eric Pang [:epang] UX]

(In reply to Alberto Pastor [:albertopq] from comment #12)
> Then I don't understand this bug. If I'm getting your reply correctly, you
> want the statusbar to be shown from the background app. In that case, the
> statusbar should be shown with the wallpaper background if the SIM pin
> dialog is shown in top of the homescreen, shouldn't it?
> 
> At the other hand, the user can always skip by clicking the 'Skip' button,
> so setting the statusbar always black (or the dialog color) and removing the
> rocketbar could potentially be an option.
> 
> Could you please clarify what's the expected behavior for the homecreen?
> Thanks!

Hey Alberto, sorry I didn't realize appears from the home screen.  This is a bit of a tricky screen because of the styling.. it doesn't look like a normal dialog (which are usually dark) it resembles a settings screen.  For that reason I think it makes more sense to go with your second option of setting the status bar background to the dialog colour.  Double checking with Rob/Jacqueline to double check.

Comment 14

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1159858-statusbar-sim-pin > mozilla-b2g:master

Comment 15

[Alberto Pastor [:albertopq]]

Comment on attachment 8684290 [details] [review]
[gaia] albertopq:1159858-statusbar-sim-pin > mozilla-b2g:master

Eric, could you confirm this is the expected behavior? Thanks!

Comment 16

[Alberto Pastor [:albertopq]]

Attachment: sim-dialog.png

There you go!

Comment 17

[Alberto Pastor [:albertopq]]

We are going to migrate all the system dialogs to WebComponents, so this issue will be fixed for free

Comment 18

[Jacqueline Savory [:jsavory] UX]

Removing my flag as well due to being resolved as duplicate.