Closed
Bug 1159923
Opened 9 years ago
Closed 9 years ago
Take bug 1140105 "Can't query for a specific font face when the selection is collapsed" in TB 38
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird38+ fixed, thunderbird39 affected, thunderbird40 fixed)
People
(Reporter: jorgk-bmo, Unassigned)
References
Details
Attachments
(1 file)
6.82 KB,
patch
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1140105 +++ Consider taking bug 1140105 in THUNDERBIRD_38_VERBRANCH for Thunderbird 38.
Comment 1•9 years ago
|
||
Is this patch different from what landed on mozilla-central? The normal practice to uplift a change is to do hg transplant from a specific hg landing on mozilla-central using the patch reference rather than a diff on a bug.
Updated•9 years ago
|
tracking-thunderbird38:
--- → +
Comment 2•9 years ago
|
||
I'm going to wait until beta 5 to consider this. In the meantime, what does "collapse the selection" mean in the parent bug STR?
Reporter | ||
Comment 3•9 years ago
|
||
Yes, this patch is different from what landed on mozilla-central. The patch that was approved there couldn't be landed, since due to bug 1147412 it couldn't be applied any more. So this patch here is a predecessor of the applied patch, it's attachment 8595402 [details] [diff] [review]. The fix is essentially a "one liner": if (aValue) { tOutString.Assign(*aValue); } The rest is for testing. Collapsed selection means that you see a caret while typing and nothing is selected, the selection is collapsed to a single point. This is the normal selection when typing e-mail. In this state, the font menu that you get with "Format > Font" when composing a message doesn't work. Try it, it takes 10 seconds to try on any e-mail you are writing.
Comment 4•9 years ago
|
||
Comment on attachment 8599559 [details] [diff] [review] Patch adapted to THUNDERBIRD_38_VERBRANCH https://hg.mozilla.org/releases/mozilla-esr38/rev/13d78cb17d8a For some reason the approval-comm-thunderbird38 flags are missing. a=rkent for THUNDERBIRD_38_VERBRANCH
Updated•9 years ago
|
status-thunderbird38:
--- → fixed
status-thunderbird39:
--- → affected
status-thunderbird40:
--- → fixed
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•