1159938 - `this._inspector.change is not a function` error after saving a text node value in markup view

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Brian Grinstead [:bgrins]]

After editing a text node I'm seeing an error in the console.  I'm seeing it in a 39 build also.

Full Stack: MarkupView.prototype.nodeChanged@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:1213:7
TextEditor/<.done/</</</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:2277:15
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:867:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:746:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:37
Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:688:5
this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:709:7
this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:671:7
Front<.onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1217:7
DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:953:7
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:561:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:82:14

Comment 1

[Patrick Brosset <:pbro>]

Oh that's right, I saw that a few times recently too, and I remember looking for the change function in the code and couldn't find it. Going through change history, I couldn't find it there either.
I think this has been dead code for a while, but maybe some recent change made it be called again or something.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: node-changed.patch

Remove dead nodeChanged() function.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=970394220e0e

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Maybe worth uplifting?

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #3)
> Maybe worth uplifting?

Yeah, maybe.  It's not affecting the user (other than spewing to the console), but it's also a simple patch that should apply cleanly.

Comment 5

[Brian Grinstead [:bgrins]]

remote:   https://hg.mozilla.org/integration/fx-team/rev/7278397ba6dc

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7278397ba6dc