1159961 - Add a Reading List dynamic home panel type

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect, P5)

Description

[Nick Alexander :nalexander [he/him]]

This came up in a meeting with mfinkle today, so I'd like to surface it more broadly.

Right now, Fennec implements a (beautiful) Reading List home panel, backed by its own (local-only) data store.  One way to broaden this work would be to make a dynamic panel view type that displays as the current Reading List does.  Then the data could be pulled from a service (Pocket?) and get the benefit of the Reading List panel UX and interaction work.

Comment 1

[Nick Alexander :nalexander [he/him]]

margaret: you are best positioned to talk about how much work this is technically, and perhaps to drop some code links.  I know you are adding a new "Speed Dial" dynamic panel type; can you link to that ticket?

Comment 2

[:Margaret Leibovic]

Thanks for filing.

To implement a new type of list display, I would just add support for a new Item type that can be displayed in View.LIST views.

However, by default, LIST views are populated with Item.ARTICLE view types:
https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Home.jsm/panels#Item_types

These are specified in the ViewConfig, and then created here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/PanelItemView.java#77

From this layout:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/panel_article_item.xml

So what exactly is it that you would like to see from the reading list styles in the current home panel list styles? I feel like these are actually very similar right now (and the dynamic panels are intended to look like the reading list), so maybe this would just involve tweaking the current ArticleItemView.

And then perhaps we should add a new Item.SITE type or something like that to create lists of sites more similar to what we ship in our other home panels.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to :Margaret Leibovic from comment #2)
> Thanks for filing.
> 
> To implement a new type of list display, I would just add support for a new
> Item type that can be displayed in View.LIST views.
> 
> However, by default, LIST views are populated with Item.ARTICLE view types:
> https://developer.mozilla.org/en-US/Add-ons/Firefox_for_Android/API/Home.jsm/
> panels#Item_types
> 
> These are specified in the ViewConfig, and then created here:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/
> PanelItemView.java#77
> 
> From this layout:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/
> layout/panel_article_item.xml
> 
> So what exactly is it that you would like to see from the reading list
> styles in the current home panel list styles? I feel like these are actually
> very similar right now (and the dynamic panels are intended to look like the
> reading list), so maybe this would just involve tweaking the current
> ArticleItemView.

I did not know this.  I think we should make a separate "two line view" panel item, for displaying, e.g. bookmarks from a third party service.  (I know that Pinterest is picture-oriented, but they might want to show bookmark like information?)  And then we should improve the existing article view to provide more of Pocket/third-party-App's value -- read/unread, percent complete, length, etc.  I was not aware that the current layout was considered an article layout.  I think antlam has quite different mocks for article layouts; we should implement that (for us and for panels!).

Comment 4

[Firefox Bug Husbandry Bot]

Bulk move: https://bugzilla.mozilla.org/show_bug.cgi?id=1399539

Comment 5

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.