1159981 - MozReview incorrectly assumes review identifier is unique across repos

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Chris Manchester (limited bugmail, email directly)]

I just pushed a commit for bug 1149670 (note mozreview requests on two repos in the bug). One of links I got from pushing is https://reviewboard.mozilla.org/r/7921/

I published this review request, but noticed no bugzilla update. I saw this earlier this week and filed bug 1158995, where mcote informed me the problem was working with a child commit, and this appears to be the case, however the review request is labeled "Root review request" and the commits area is blank. After a short time this was marked as discarded (without my intervention), although the parent (https://reviewboard.mozilla.org/r/7919/) still claims it depends on it.

Comment 1

[Steven MacLeod [:smacleod]]

(In reply to Chris Manchester [:chmanchester] from comment #0)
> I just pushed a commit for bug 1149670 (note mozreview requests on two repos
> in the bug). One of links I got from pushing is
> https://reviewboard.mozilla.org/r/7921/
> 
> I published this review request, but noticed no bugzilla update. I saw this
> earlier this week and filed bug 1158995, where mcote informed me the problem
> was working with a child commit, and this appears to be the case, however
> the review request is labeled "Root review request" and the commits area is
> blank. After a short time this was marked as discarded (without my
> intervention), although the parent (https://reviewboard.mozilla.org/r/7919/)
> still claims it depends on it.

There are definitely some cases that are broken in our MozReview code for pushes to different repos but the same bug from the same user. We're working on getting these fixed and it shouldn't be too much longer but until then it's probably best to only push to a single repo per bug.

We need to go through the code and fix up all the cases where we search by review identifier but don't provide the repository id as well.

Comment 2

[Mark Côté [:mcote]]

I am pretty sure I fixed these all while working on bug 1164932.