Closed Bug 1159990 Opened 8 years ago Closed 8 years ago

Replace nsIntRect with some specific structure for table damage areas

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

patch
70.65 KB, patch
roc
: review+
Details | Diff | Splinter Review 
Currently we use nsIntRect for table damage areas, but the terms X and Y could be confusing when we want to make table work for vertical writing modes. (It should have been confusing for RTL table I suppose.)

I propose that, instead of nsIntRect, we create a new structure, nsTableArea, and replace the fields with
x -> StartCol
y -> StartRow
width -> ColCount
height -> RowCount
XMost -> EndCol
YMost -> EndRow

We could stil use nsIntRect for the internal storage (since we could reuse code for UnionRect), but convert the wording to make more sense.
Depends on: 720142
Attached patch patch — — Splinter Review 

        Attachment #8599674 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e42e4e3139c5
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox40:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

          You need to log in
          before you can comment on or make changes to this bug.