1159990 - Replace nsIntRect with some specific structure for table damage areas

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently we use nsIntRect for table damage areas, but the terms X and Y could be confusing when we want to make table work for vertical writing modes. (It should have been confusing for RTL table I suppose.)

I propose that, instead of nsIntRect, we create a new structure, nsTableArea, and replace the fields with
x -> StartCol
y -> StartRow
width -> ColCount
height -> RowCount
XMost -> EndCol
YMost -> EndRow

We could stil use nsIntRect for the internal storage (since we could reuse code for UnionRect), but convert the wording to make more sense.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a0352cfccf9

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e42e4e3139c5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e42e4e3139c5