Replace nsIntRect with some specific structure for table damage areas

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla40
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Currently we use nsIntRect for table damage areas, but the terms X and Y could be confusing when we want to make table work for vertical writing modes. (It should have been confusing for RTL table I suppose.)

I propose that, instead of nsIntRect, we create a new structure, nsTableArea, and replace the fields with
x -> StartCol
y -> StartRow
width -> ColCount
height -> RowCount
XMost -> EndCol
YMost -> EndRow

We could stil use nsIntRect for the internal storage (since we could reuse code for UnionRect), but convert the wording to make more sense.
Depends on: 720142
Posted patch patchSplinter Review
Attachment #8599674 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/e42e4e3139c5
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.