Closed
Bug 1160030
Opened 9 years ago
Closed 9 years ago
Use TEST_HARNESS_FILES to install Robocop test files
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(2 files, 1 obsolete file)
With a work-in-progress --disable-compile-environment, I was seeing some strange hard linking behaviour with directories in an INSTALL_TARGET. This ticket tracks making life simpler (and faster!) by using TEST_HARNESS_FILES in build/mobile/robocop.
Assignee | ||
Comment 1•9 years ago
|
||
/r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj Pull down this commit: hg pull -r 3dff590c5c40213b5c800e5fd111c77c0d3c32c5 https://reviewboard-hg.mozilla.org/gecko/
Assignee | ||
Updated•9 years ago
|
Attachment #8599688 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8599688 [details] MozReview Request: bz://1160030/nalexander /r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj Pull down this commit: hg pull -r 3dff590c5c40213b5c800e5fd111c77c0d3c32c5 https://reviewboard-hg.mozilla.org/gecko/
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/7927/#review6681 Ship It!
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/7927/#review6683 Ship It!
Comment 5•9 years ago
|
||
Comment on attachment 8599688 [details] MozReview Request: bz://1160030/nalexander https://reviewboard.mozilla.org/r/7925/#review6685 Ship It!
Attachment #8599688 -
Flags: review?(nfroyd) → review+
Comment 6•9 years ago
|
||
Sigh, someday reviewboard will be usable.
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8599688 [details] MozReview Request: bz://1160030/nalexander /r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj /r/7941 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop ini files. r=froydnj Pull down these commits: hg pull -r 3f03344ba9613049033266e0a639dd66f3f6cc5b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599688 -
Flags: review+ → review?(nfroyd)
Comment 8•9 years ago
|
||
https://reviewboard.mozilla.org/r/7941/#review6729 Ship It!
Comment 9•9 years ago
|
||
Comment on attachment 8599688 [details] MozReview Request: bz://1160030/nalexander https://reviewboard.mozilla.org/r/7925/#review6731 Ship It!
Attachment #8599688 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0ae19cd0a1f7 https://hg.mozilla.org/integration/fx-team/rev/3c3f5eb8b3d6
Comment 11•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #0) > With a work-in-progress --disable-compile-environment, I was seeing some > strange hard linking behaviour with directories in an INSTALL_TARGET. We should, in fact, reject directories in INSTALL_TARGET. Because that just works by luck, presently, because we're doing symlinks on unix, and it just happens that those robocop files are never built on windows, where that wouldn't work.
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0ae19cd0a1f7 https://hg.mozilla.org/mozilla-central/rev/3c3f5eb8b3d6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Assignee | ||
Comment 13•9 years ago
|
||
Attachment #8599688 -
Attachment is obsolete: true
Attachment #8620199 -
Flags: review+
Attachment #8620200 -
Flags: review+
Assignee | ||
Comment 14•9 years ago
|
||
Assignee | ||
Comment 15•9 years ago
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•