Use TEST_HARNESS_FILES to install Robocop test files

RESOLVED FIXED in Firefox 40

Status

defect
RESOLVED FIXED
4 years ago
Last year

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
mozilla40
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

With a work-in-progress --disable-compile-environment, I was seeing some strange hard linking behaviour with directories in an INSTALL_TARGET.  This ticket tracks making life simpler (and faster!) by using TEST_HARNESS_FILES in build/mobile/robocop.
/r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj

Pull down this commit:

hg pull -r 3dff590c5c40213b5c800e5fd111c77c0d3c32c5 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599688 - Flags: review?(nfroyd)
Comment on attachment 8599688 [details]
MozReview Request: bz://1160030/nalexander

/r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj

Pull down this commit:

hg pull -r 3dff590c5c40213b5c800e5fd111c77c0d3c32c5 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8599688 [details]
MozReview Request: bz://1160030/nalexander

https://reviewboard.mozilla.org/r/7925/#review6685

Ship It!
Attachment #8599688 - Flags: review?(nfroyd) → review+
Sigh, someday reviewboard will be usable.
Comment on attachment 8599688 [details]
MozReview Request: bz://1160030/nalexander

/r/7927 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop test files. r=froydnj
/r/7941 - Bug 1160030 - Use TEST_HARNESS_FILES to install Robocop ini files. r=froydnj

Pull down these commits:

hg pull -r 3f03344ba9613049033266e0a639dd66f3f6cc5b https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599688 - Flags: review+ → review?(nfroyd)
Comment on attachment 8599688 [details]
MozReview Request: bz://1160030/nalexander

https://reviewboard.mozilla.org/r/7925/#review6731

Ship It!
Attachment #8599688 - Flags: review?(nfroyd) → review+
(In reply to Nick Alexander :nalexander from comment #0)
> With a work-in-progress --disable-compile-environment, I was seeing some
> strange hard linking behaviour with directories in an INSTALL_TARGET.

We should, in fact, reject directories in INSTALL_TARGET. Because that just works by luck, presently, because we're doing symlinks on unix, and it just happens that those robocop files are never built on windows, where that wouldn't work.
https://hg.mozilla.org/mozilla-central/rev/0ae19cd0a1f7
https://hg.mozilla.org/mozilla-central/rev/3c3f5eb8b3d6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Blocks: 1160662
Attachment #8599688 - Attachment is obsolete: true
Attachment #8620199 - Flags: review+
Attachment #8620200 - Flags: review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.