1160066 - Some edit times are incorrect in MDN, e.g. Revision History | Git

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Description

[Adrian Aichner [:anaran]]

See these links:

https://developer.mozilla.org/en-US/docs/Glossary/Git$revision/795419
https://developer.mozilla.org/en-US/profiles/Sheppy
https://developer.mozilla.org/en-US/docs/Glossary/Git$compare?to=795619&from=795615
https://developer.mozilla.org/en-US/docs/Glossary/Git$revision/795619
https://developer.mozilla.org/en-US/docs/Glossary/Git$compare?to=795615&from=795409
https://developer.mozilla.org/en-US/docs/Glossary/Git$revision/795615
https://developer.mozilla.org/en-US/docs/Glossary/Git$compare?to=795409&from=787048
https://developer.mozilla.org/en-US/docs/Glossary/Git$revision/795409
https://developer.mozilla.org/en-US/profiles/maybe

  referenced from

https://developer.mozilla.org/en-US/docs/Glossary/Git$history

Details:

All the following edits were made within minutes of each other between
Apr 29, 2015 11:46:52 PM CET DST (+0200)
and
Apr 29, 2015 11:42:29 PM CET DST (+0200)
also verified against my #mdn IRC backlog.

Yet two edits are 6 hours ahead of their time. Could same admin panel be involve here, lying about is time?

The exhibit below was rendered in

> (new Date).getTimezoneOffset()
>     -120
> document.lastModified
>     04/30/2015 09:43:47
> navigator.buildID
>     20150429030202
> navigator.javaEnabled()
>     true
> navigator.language
>     de
> navigator.languages
>     de,en-US
> navigator.userAgent
>     Mozilla/5.0 (Windows NT 5.1; rv:40.0) Gecko/20100101 Firefox/40.0

Apr 29, 2015 11:46:52 PM
Sheppy
Corrected capitalization in title
Previous
Apr 30, 2015 5:45:13 AM
Sheppy
Corrected capitalization in titleTemporary Glossary/Git
Previous
Apr 30, 2015 5:44:56 AM
Sheppy
Corrected capitalization in titleGlossary/GIT Temporary
Previous
Apr 29, 2015 11:42:29 PM
maybe
Use official definition from git-scm.com


http://mzl.la/1vxCDgA

Comment 1

[Jean-Yves Perrier [:teoli]]

I wonder if page move is converting a date in the wrong direction to store it in the revision created

Because:
23:42 CEST (DST) = 21:42 UTC = 22:42 BST = 17:42 EDT = 14:42 PDT

21:42 + 07:00 = 04:42 (and in winter — that is PST — + 08:00 05:52)

(It should be 21:42 - 07:00 if the original internal date is PDT or -08:00 if PST)

Needinfo our back-end benevolent overlords, because I don't know of the consequences of wrong dates in the DB and that's ringing an alarm bell in my head. Hopefully for nothing.

Comment 2

[Adrian Aichner [:anaran]]

(In reply to Jean-Yves Perrier [:teoli] from comment #1)
> I wonder if page move is converting a date in the wrong direction to store
> it in the revision created
> 
> Because:
> 23:42 CEST (DST) = 21:42 UTC = 22:42 BST = 17:42 EDT = 14:42 PDT
> 
> 21:42 + 07:00 = 04:42 (and in winter — that is PST — + 08:00 05:52)
> 
> (It should be 21:42 - 07:00 if the original internal date is PDT or -08:00
> if PST)
> 
> Needinfo our back-end benevolent overlords, because I don't know of the
> consequences of wrong dates in the DB and that's ringing an alarm bell in my
> head. Hopefully for nothing.

One would hope all these dates are stored with
> date.toJSON()
or
> date.getTime()
in the database, conceptually.

Comment 3

[Eric Shepherd [:sheppy]]

This has potential of explaining the occasional problems we've had with the version history winding up with entries out of order, etc.

Comment 4

[Adrian Aichner [:anaran]]

(In reply to Eric Shepherd [:sheppy] from comment #3)
> This has potential of explaining the occasional problems we've had with the
> version history winding up with entries out of order, etc.

Yes, and people not finding their edits in the dashboard in the expected time range.

Anything special about those out-of-order edits you made, which hasn't been mentioned above (page move)?

Comment 5

[Jannis Leidel [:jezdez]]

Sorry, I'm deep in other work right now (upgrade to latest Python/Django versions), but would like to say that given the age of the Django system we're using there is little chance we do date/time handling correctly. This is a legacy issue and will be possible to be fixed once we're on a more modern version of Django.

Comment 6

[James Bennett [:ubernostrum]]

Yeah, this is something that requires investigation post-upgrade.

Comment 7

[Jean-Yves Perrier [:teoli]]

Cool! I was only afraid that this could have been an urgent problem (to prevent some bad behavior that I didn't saw). Thanks guys.

Comment 8

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.