1160083 - Text selection handles visible after removing textarea

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[ivan]

Attachment: Screenshot_2015-04-30-11-11-10.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0 Iceweasel/35.0.1
Build ID: 20150130021009

Steps to reproduce:

I've made a test case at https://gist.github.com/IvanSanchez/19236943e971c09263d3

It seems that the necessary conditions to reproduce this are:
- Programatically select all text in a textarea
- Manually deselect and select some text
- Attach a jQuery 'focusout' event handler to a textarea
- Hide the parent element of the textarea on a timeout on the focusout element handler




Actual results:

The text selection handles will remain visible (and draggable) on the screen, *even when switching to any other tab*.

Comment 1

[ivan]

Attachment: Screenshot_2015-04-30-11-10-53.png

Comment 2

[Mark Capella [:capella]]

logcat errors are:

D/GeckoBrowser(25359): Unexpected failure during caret attach: Element disabled, handled natively, or not editable.
Error: "NS_ERROR_NOT_INITIALIZED: Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIEditor.selection]" {file: "chrome://browser/content/SelectionHandler.js" line: 936}]


Tricky edgecase! We're trying to attach a caret into the textarea that no longer contains an editor, and we fail in _clearSelection() while trying to determine how properly to close the previous selection first.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/SelectionHandler.js?rev=1be077af56e3&mark=1209-1209#1204


fyi, we're currently migrating towards Bug 1168847 - [meta] Enable Gecko text selection carets by default, and this won't be an issue there.

Comment 3

[Mark Capella [:capella]]

Forgot I wanted to thank ivan for the report and the detailed testcase (That's always extremely helpful!), and to apologise that I didn't notice this for some reason earlier.

Comment 4

[ivan]

(In reply to Mark Capella [:capella] from comment #3)
> Forgot I wanted to thank ivan for the report and the detailed testcase
> (That's always extremely helpful!), and to apologise that I didn't notice
> this for some reason earlier.

No problem, Mark. I know how being on that side of the bugtracker feels like ;-)

Comment 5

[Mark Capella [:capella]]

Checking back in with Ivan. Our new AccessibleCaret implementation completely replaces the old Java handles involved in this issue. General code changes (testable in nightly) seem to corrected (new) / invalidated (old) this problem.

Can you try this out and confirm my own testing? We're trying to close as many old issues as possible, where appropriate.

Comment 6

[ivan]

I've just tested with Firefox Nightly 47.0a1 (2016-02-11).

Apparently I'm still able to reproduce the bug, albeit with a different set of event handlers and timeouts than originally (the one I used to workaround the original bug). I haven't had time to isolate the problem. I'll attach some screenshots.

The *good* part is that, even though the handles are visible when the <textarea> is not, the handles do dissapear as soon as any other element in the page is focused (i.e. as soon as the user touches anything). So now it's more like a small glitch and less than a ux-breaking bug.

[:capella] : I don't know if the right course of action is to close the bug or downgrade it to "trivial" importance and spend time isolating the minimal conditions to trigger it.

Comment 7

[ivan]

Attachment: Screenshot_2016-02-12-12-31-10.png - selecting text

Comment 8

[ivan]

Attachment: Screenshot_2016-02-12-12-31-40.png - handles still visible

Comment 9

[Mark Capella [:capella]]

I think you said there's new STR and test-code than what you posted in comment 0 to force this bug (?) Can you post that also? In any case, let's leave this open for now.

Comment 10

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.