XULElement::LoadSrc() should check whether we successfully created a new frameLoader before trying to call SetIsPrerendered() on it

RESOLVED FIXED in Firefox 40

Status

()

Core
DOM
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
1601         slots->mFrameLoader = nsFrameLoader::Create(this, false);
1602         if (AttrValueIs(kNameSpaceID_None, nsGkAtoms::prerendered,
1603                         NS_LITERAL_STRING("true"), eIgnoreCase)) {
1604             nsresult rv = slots->mFrameLoader->SetIsPrerendered();
1605             NS_ENSURE_SUCCESS(rv,rv);
1606         }
1607 
1608         NS_ENSURE_TRUE(slots->mFrameLoader, NS_OK);

The current code checks |slots->mFrameLoader| after trying to call |slots->mFrameLoader->SetIsPrerendered()|.
(Assignee)

Comment 1

3 years ago
Created attachment 8599794 [details] [diff] [review]
0001-Bug-1160098-XULElement-LoadSrc-should-check-whether-.patch
Attachment #8599794 - Flags: review?(bugs)

Updated

3 years ago
Attachment #8599794 - Flags: review?(bugs) → review+

Comment 2

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b318ff4e610e
https://hg.mozilla.org/mozilla-central/rev/b318ff4e610e
Assignee: nobody → ttaubert
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.