Restart bluetoothd daemon automatically for API V2

RESOLVED FIXED in Firefox 42

Status

Firefox OS
Bluetooth
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

Tracking

unspecified
FxOS-S2 (10Jul)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

STR:
1. Kill bluetoothd daemon
2. do "adb shell ps | grep bluetoothd" to see that bluetoothd didn't restart

Expected:
bluetoothd should have automatically restarted.

Toggling bluetooth in settings restarts the daemon which we shouldn't have to.
See Also: → bug 1143925

Updated

3 years ago
Blocks: 1115656
Assignee: nobody → shuang
Created attachment 8623711 [details] [diff] [review]
bug1160126-mc.patch
Attachment #8623711 - Flags: review?(joliu)
I found some parts are missing in v2. Here is the fix.
The logic is the same as v1 api.
Comment on attachment 8623711 [details] [diff] [review]
bug1160126-mc.patch

Review of attachment 8623711 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good to me.

Thanks,
Jocelyn

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +253,5 @@
>      MOZ_ASSERT(NS_IsMainThread());
>  
>      BT_LOGR("BluetoothInterface::Disable failed: %d", aStatus);
>  
> +    BluetoothService::AcknowledgeToggleBt(false);

Please rebase on latest m-c, then we could remove the #ifndef directly.
Attachment #8623711 - Flags: review?(joliu) → review+
Attachment #8623711 - Attachment is obsolete: true
Created attachment 8628733 [details] [diff] [review]
Bug 1160126 - Restart bluetoothd daemon automatically for API V2, r=jocelyn

Rebase to the latest m-c.
https://hg.mozilla.org/mozilla-central/rev/fb2d2a3c2347
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S2 (10Jul)
You need to log in before you can comment on or make changes to this bug.