Closed
Bug 1160126
Opened 10 years ago
Closed 10 years ago
Restart bluetoothd daemon automatically for API V2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
FxOS-S2 (10Jul)
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: shawnjohnjr, Assigned: shawnjohnjr)
References
Details
Attachments
(1 file, 1 obsolete file)
STR:
1. Kill bluetoothd daemon
2. do "adb shell ps | grep bluetoothd" to see that bluetoothd didn't restart
Expected:
bluetoothd should have automatically restarted.
Toggling bluetooth in settings restarts the daemon which we shouldn't have to.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → shuang
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8623711 -
Flags: review?(joliu)
Assignee | ||
Comment 2•10 years ago
|
||
I found some parts are missing in v2. Here is the fix.
Assignee | ||
Comment 3•10 years ago
|
||
The logic is the same as v1 api.
Comment 4•10 years ago
|
||
Comment on attachment 8623711 [details] [diff] [review]
bug1160126-mc.patch
Review of attachment 8623711 [details] [diff] [review]:
-----------------------------------------------------------------
The code looks good to me.
Thanks,
Jocelyn
::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +253,5 @@
> MOZ_ASSERT(NS_IsMainThread());
>
> BT_LOGR("BluetoothInterface::Disable failed: %d", aStatus);
>
> + BluetoothService::AcknowledgeToggleBt(false);
Please rebase on latest m-c, then we could remove the #ifndef directly.
Attachment #8623711 -
Flags: review?(joliu) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8623711 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Rebase to the latest m-c.
Assignee | ||
Comment 7•10 years ago
|
||
Comment 8•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S2 (10Jul)
You need to log in
before you can comment on or make changes to this bug.
Description
•