1160126 - Restart bluetoothd daemon automatically for API V2

Status: RESOLVED FIXED

Description

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

STR:
1. Kill bluetoothd daemon
2. do "adb shell ps | grep bluetoothd" to see that bluetoothd didn't restart

Expected:
bluetoothd should have automatically restarted.

Toggling bluetooth in settings restarts the daemon which we shouldn't have to.

Comment 1

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

Created attachment 8623711 [details] [diff] [review]
bug1160126-mc.patch

Comment 2

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

I found some parts are missing in v2. Here is the fix.

Comment 3

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

The logic is the same as v1 api.

Comment 4

[Jocelyn Liu [:jocelyn] [:joliu]]

Comment on attachment 8623711 [details] [diff] [review]
bug1160126-mc.patch

Review of attachment 8623711 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks good to me.

Thanks,
Jocelyn

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +253,5 @@
>      MOZ_ASSERT(NS_IsMainThread());
>  
>      BT_LOGR("BluetoothInterface::Disable failed: %d", aStatus);
>  
> +    BluetoothService::AcknowledgeToggleBt(false);

Please rebase on latest m-c, then we could remove the #ifndef directly.

Comment 5

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

https://hg.mozilla.org/try/pushloghtml?changeset=09cf838d2539
https://treeherder.mozilla.org/#/jobs?repo=try&revision=09cf838d2539

Comment 6

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

Created attachment 8628733 [details] [diff] [review]
Bug 1160126 - Restart bluetoothd daemon automatically for API V2, r=jocelyn

Rebase to the latest m-c.

Comment 7

[Shawn Huang [:shawnjohnjr] (left Mozilla)]

https://hg.mozilla.org/integration/b2g-inbound/rev/fb2d2a3c2347
https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=fb2d2a3c2347

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fb2d2a3c2347