Closed
Bug 1160137
Opened 9 years ago
Closed 9 years ago
Windows 8 x64 debug spidermonkey shell is not built with --enable-64bit.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla40
People
(Reporter: arai, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.05 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/js/src/devtools/automation/autospider.sh#106 > if [ "$platform" = "win64" ]; then > USE_64BIT=true > fi platform is "win64-debug" on Windows x64 debug, and the condition doesn't match. http://ftp.mozilla.org/pub/mozilla.org/spidermonkey/try-builds/arai_a@mac.com-87f7919da0f1/try-win64-debug/try_win64-debug_spidermonkey-compacting-bm83-try1-build45.txt.gz > + platform=win64-debug >... > + USE_64BIT=false > + [[ msys == darwin* ]] > + '[' msys = linux-gnu ']' > + '[' msys = msys ']' > + USE_64BIT=false > + '[' win64-debug = win64 ']' > + MAKE=mozmake
Assignee | ||
Comment 1•9 years ago
|
||
setting USE_64BIT=true results in same failure as x64 opt builds. https://treeherder.mozilla.org/#/jobs?repo=try&revision=5021b3857357&exclusion_profile=false > configure(6317) : error C2118: negative subscript
Assignee | ||
Comment 2•9 years ago
|
||
complementary patch for bug 1160490. this patch enables USE_64BIT on debug build. Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=95e8d0c02f82&exclusion_profile=false
Assignee: nobody → arai.unmht
Attachment #8600319 -
Flags: review?(sphink)
Comment 3•9 years ago
|
||
Comment on attachment 8600319 [details] [diff] [review] Use 64bit on Windows 8 x64 debug spidermonkey shell build. Review of attachment 8600319 [details] [diff] [review]: ----------------------------------------------------------------- It's so nice to have someone taking care of these.
Attachment #8600319 -
Flags: review?(sphink) → review+
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e0a963817671
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/55c3df7a17a9
status-firefox39:
--- → fixed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-esr38/rev/72e0ef129d77
status-firefox-esr38:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•