Closed
Bug 1160163
Opened 9 years ago
Closed 9 years ago
Add a method to get an areana to decommit for use by GCRuntime::decommitArenas()
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
7.47 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
At the moment we call Chunk::allocateArena() when decommitting which initialises the arena header unnecessarily. It also requires passing a think kind which is misleading in this context. We should have a method to just get an arena to decommit.
Assignee | ||
Comment 1•9 years ago
|
||
This adds a method to decommit an arena to the Chunk and so removes the ArenaDecommitState argument to releaseArena(). The refactoring went slightly further than originally intended and moved the internals of decommitting into Chunk but the result is better I think.
Assignee: nobody → jcoppeard
Attachment #8601423 -
Flags: review?(terrence)
Comment 2•9 years ago
|
||
Comment on attachment 8601423 [details] [diff] [review] bug1160163-refactor-decommit Review of attachment 8601423 [details] [diff] [review]: ----------------------------------------------------------------- Wow, that's much, much nicer!
Attachment #8601423 -
Flags: review?(terrence) → review+
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e474db0bdba5
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•