"mach xpcshell-test" without a test path no longer works

RESOLVED FIXED in Firefox 40

Status

Testing
XPCShell Harness
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: past, Assigned: chmanchester)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

This used to work until yesterday and it still works for mochitest-chrome (mach mochitest-chrome --tag devtools), so the breakage seems to be xpcshell-specific:

$ mach xpcshell-test --tag devtools
From _tests: Kept 35668 existing; Added/updated 0; Removed 0 files and 0 directories.
We could not find an xpcshell test for the passed test path. Please select a path that is a test file or is a directory containing xpcshell tests.
$ head -2 toolkit/devtools/tests/unit/xpcshell.ini 
[DEFAULT]
tags = devtools
(Assignee)

Comment 1

3 years ago
I'm bisecting this.
Assignee: nobody → cmanchester
(Assignee)

Updated

3 years ago
Blocks: 1158019
(Assignee)

Comment 2

3 years ago
|./mach xpcshell-test| with no arguments also does something crazy.
Summary: "mach xpcshell-test --tag devtools" no longer works → "mach xpcshell-test" without a test path no longer works
(Assignee)

Comment 3

3 years ago
Created attachment 8599987 [details]
MozReview Request: bz://1160164/chmanchester

/r/7949 - Bug 1160164 - Run "all the tests" when invoking xpcshell's mach command with no arguments instead of passing "all" to the test resolver.;r=ahal

Pull down this commit:

hg pull -r f534458bd618ec771b1aecc2f77dccbb60f0f7b2 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599987 - Flags: review?(ahalberstadt)
(Assignee)

Comment 4

3 years ago
|./mach xpcshell-test| only sort of worked by accident before. "all" got passed to the test resolver, which interpreted each letter as a path input because strings are iterable, so any path with one of these inputs as a substring would match, meaning any test with "a" or "l" in its path would be run (this is all but 276 of 2,536 tests when I try it locally).
Comment on attachment 8599987 [details]
MozReview Request: bz://1160164/chmanchester

Flag didn't get flipped.
Attachment #8599987 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/0d5bddff56b4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Comment 9

3 years ago
Comment on attachment 8599987 [details]
MozReview Request: bz://1160164/chmanchester
Attachment #8599987 - Attachment is obsolete: true
Attachment #8620202 - Flags: review+
(Assignee)

Comment 10

3 years ago
Created attachment 8620202 [details]
MozReview Request: Bug 1160164 - Run "all the tests" when invoking xpcshell's mach command with no arguments instead of passing "all" to the test resolver.;r=ahal
You need to log in before you can comment on or make changes to this bug.