1160194 - Time set unnecessarily in install_app

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

ADBDeviceHandler's install_app() calls set_device_time(). I don't think time-setting is needed, and it seems to be implicated in bug 1051908.

On the Android emulators, time is synced with the host, so the install_app time set does nothing:

13:07:20     INFO - Getting output from command: ['/builds/slave/test/build/android-sdk18/platform-tools/adb', '-s', 'emulator-5554', 'shell', 'date']
13:07:20     INFO - Copy/paste: /builds/slave/test/build/android-sdk18/platform-tools/adb -s emulator-5554 shell date
13:07:20     INFO - Reading from file tmpfile_stdout
13:07:20     INFO - Output received:
13:07:20     INFO -  Tue Apr 28 13:07:20 PDT 2015
13:07:20     INFO - Tue Apr 28 13:07:20 PDT 2015
13:07:20     INFO - Running command: ['/builds/slave/test/build/android-sdk18/platform-tools/adb', '-s', 'emulator-5554', 'shell', 'date', '-s', '20150428.130720']
13:07:20     INFO - Copy/paste: /builds/slave/test/build/android-sdk18/platform-tools/adb -s emulator-5554 shell date -s 20150428.130720
13:07:20     INFO -  Tue Apr 28 13:07:20 PDT 2015
13:07:20     INFO - Return code: 0
13:07:20     INFO - Getting output from command: ['/builds/slave/test/build/android-sdk18/platform-tools/adb', '-s', 'emulator-5554', 'shell', 'date']
13:07:20     INFO - Copy/paste: /builds/slave/test/build/android-sdk18/platform-tools/adb -s emulator-5554 shell date
13:07:21     INFO - Reading from file tmpfile_stdout
13:07:21     INFO - Output received:
13:07:21     INFO -  Tue Apr 28 13:07:20 PDT 2015
13:07:21     INFO - Tue Apr 28 13:07:20 PDT 2015


Time setting is needed on pandas, but those jobs use a different mechanism.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: simplify adb install_app

This removes the call to set the time on the device; it is never needed on the emulators, and seems to hang intermittently.

I thought the comments here had outlived their usefulness, and some obviously pertain to Tegras, so removed them.

I also noticed we check for prior application installation (ls /data/data/<package>), but that is always negative in CI, since the emulators start with a fresh image. I removed this check also, simply to remove another possible adb hang.

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c531f21679e

15:30:23     INFO - Getting output from command: ['/builds/slave/test/build/android-sdk18/platform-tools/adb', '-s', 'emulator-5554', 'shell', 'getprop', 'sys.boot_completed']
15:30:23     INFO - Copy/paste: /builds/slave/test/build/android-sdk18/platform-tools/adb -s emulator-5554 shell getprop sys.boot_completed
15:30:24     INFO - Reading from file tmpfile_stdout
15:30:24     INFO - Output received:
15:30:24     INFO -  1
15:30:24     INFO - Installing Fennec for test-1
15:30:24     INFO - Getting output from command: ['/builds/slave/test/build/android-sdk18/platform-tools/adb', '-s', 'emulator-5554', 'install', '-r', '/builds/slave/test/build/fennec-40.0a1.en-US.android-arm.apk']
15:30:24     INFO - Copy/paste: /builds/slave/test/build/android-sdk18/platform-tools/adb -s emulator-5554 install -r /builds/slave/test/build/fennec-40.0a1.en-US.android-arm.apk
15:32:09     INFO - Reading from file tmpfile_stdout
15:32:09     INFO - Output received:
15:32:09     INFO -  	pkg: /data/local/tmp/fennec-40.0a1.en-US.android-arm.apk
15:32:09     INFO -  Success
15:32:09     INFO - Reading from file tmpfile_stderr
15:32:09     INFO - Finished installing apps for test-1

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 8600396 [details] [diff] [review]
simplify adb install_app

Yay for removing spurious code!

Comment 4

[Geoff Brown [:gbrown] (pto Apr 11-18)]

https://hg.mozilla.org/build/mozharness/rev/1da0d44cd6ab

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8235c9b93e8

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f8235c9b93e8