Closed Bug 1160217 Opened 5 years ago Closed 5 years ago

Intermittent browser_responsiveuiaddcustompreset.js | add preset, and selected in the list, dimension valid (width) - Got 1151, expected 456 | add preset, and selected in the list, dimension valid (height) - Got 783, expected 123

Categories

(DevTools :: Responsive Design Mode, defect)

38 Branch
x86_64
Linux
defect
Not set

Tracking

(e10s?, firefox38 unaffected, firefox38.0.5 unaffected, firefox39 unaffected, firefox40 fixed, firefox-esr31 unaffected, firefox-esr38 unaffected)

RESOLVED FIXED
Firefox 40
Tracking Status
e10s ? ---
firefox38 --- unaffected
firefox38.0.5 --- unaffected
firefox39 --- unaffected
firefox40 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: RyanVM, Assigned: mconley)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

09:00:32 INFO - 4088 INFO TEST-START | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js
09:00:32 INFO - 4089 INFO Adding a new tab with URL: 'data:text/html;charset=utf8,test custom presets in responsive mode'
09:00:32 INFO - 4090 INFO Waiting for event: 'load' on [object XULElement].
09:00:32 INFO - 4091 INFO Got event: 'load' on [object XULElement].
09:00:32 INFO - 4092 INFO URL 'data:text/html;charset=utf8,test custom presets in responsive mode' loading complete
09:00:32 INFO - 4093 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved the <key> node
09:00:32 INFO - 4094 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved keycode/key
09:00:32 INFO - 4095 INFO Waiting for event: 'on' on [object Object].
09:00:32 INFO - 4096 INFO Got event: 'on' on [object Object].
09:00:32 INFO - 4097 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | In responsive mode.
09:00:32 INFO - 4098 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | instance of the module is attached to the tab.
09:00:32 INFO - 4099 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | selected item didn't change after add preset and cancel
09:00:32 INFO - 4100 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | number of presets didn't change after add preset and cancel
09:00:32 INFO - 4101 INFO document height 854
09:00:32 INFO - 4102 INFO waiting for responsive mode to turn off
09:00:32 INFO - 4103 INFO Waiting for event: 'off' on [object Object].
09:00:32 INFO - 4104 INFO Got event: 'off' on [object Object].
09:00:32 INFO - 4105 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved the <key> node
09:00:32 INFO - 4106 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved keycode/key
09:00:32 INFO - 4107 INFO Waiting for event: 'on' on [object Object].
09:00:32 INFO - 4108 INFO Got event: 'on' on [object Object].
09:00:32 INFO - 4109 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | In responsive mode.
09:00:32 INFO - 4110 INFO 3
09:00:32 INFO - 4111 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | is the previously added preset (idx = 3) in the list of items
09:00:32 INFO - 4112 INFO checking window state
09:00:32 INFO - 4113 INFO TEST-UNEXPECTED-FAIL | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | add preset, and selected in the list, dimension valid (width) - Got 1151, expected 456
09:00:32 INFO - Stack trace:
09:00:32 INFO - chrome://mochikit/content/browser-test.js:test_is:925
09:00:32 INFO - chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js:test/<:124
09:00:32 INFO - self-hosted:InterpretGeneratorResume:716
09:00:32 INFO - self-hosted:next:674
09:00:32 INFO - test@chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js:43:3
09:00:32 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:770:9
09:00:32 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:664:7
09:00:32 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:744:59
09:00:33 INFO - 4114 INFO TEST-UNEXPECTED-FAIL | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | add preset, and selected in the list, dimension valid (height) - Got 783, expected 123
09:00:33 INFO - Stack trace:
09:00:33 INFO - chrome://mochikit/content/browser-test.js:test_is:925
09:00:33 INFO - chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js:test/<:125
09:00:33 INFO - self-hosted:InterpretGeneratorResume:716
09:00:33 INFO - self-hosted:next:674
09:00:33 INFO - test@chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js:43:3
09:00:33 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:770:9
09:00:33 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:664:7
09:00:33 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:744:59
09:00:33 INFO - 4115 INFO Waiting for event: 'off' on [object Object].
09:00:33 INFO - 4116 INFO Got event: 'off' on [object Object].
09:00:33 INFO - 4117 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved the <key> node
09:00:33 INFO - 4118 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | Successfully retrieved keycode/key
09:00:33 INFO - 4119 INFO waiting for responsive mode to turn on
09:00:33 INFO - 4120 INFO Waiting for event: 'on' on [object Object].
09:00:33 INFO - 4121 INFO Got event: 'on' on [object Object].
09:00:33 INFO - 4122 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | deleted preset 360×640 is not in the list anymore
09:00:33 INFO - 4123 INFO TEST-PASS | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | deleted preset 768×1024 is not in the list anymore
09:00:33 INFO - MEMORY STAT vsize after test: 916541440
09:00:33 INFO - MEMORY STAT residentFast after test: 225558528
09:00:33 INFO - MEMORY STAT heapAllocated after test: 102705272
09:00:33 INFO - 4124 INFO TEST-OK | browser/devtools/responsivedesign/test/browser_responsiveuiaddcustompreset.js | took 1231ms
Retriggers point at bug 1081879 as the culprit. mconley says he has a possible fix.
Blocks: 1081879
/r/7945 - Bug 1160217 - Wait for resize to complete in browser_responsiveuiaddcustompreset.js before sampling inner dimensions of content. r=?

Pull down this commit:

hg pull -r 1dae46c9a8303e11ba5a7931c3079d864333e214 https://reviewboard-hg.mozilla.org/gecko/
Comment on attachment 8599969 [details]
MozReview Request: bz://1160217/mconley

/r/7945 - Bug 1160217 - Wait for resize to complete in browser_responsiveuiaddcustompreset.js before sampling inner dimensions of content. r=?

Pull down this commit:

hg pull -r 1dae46c9a8303e11ba5a7931c3079d864333e214 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8599969 - Flags: review?(jryans)
Attachment #8599969 - Flags: review?(jryans) → review+
Comment on attachment 8599969 [details]
MozReview Request: bz://1160217/mconley

https://reviewboard.mozilla.org/r/7943/#review6779

Ship It!
https://hg.mozilla.org/mozilla-central/rev/263afadf0838
Assignee: nobody → mconley
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
No longer blocks: 1160910
Attachment #8599969 - Attachment is obsolete: true
Attachment #8620205 - Flags: review+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.