1160253 - Use mozPoisonValue in GuardObjectNotifier

Status: RESOLVED INCOMPLETE

(Core :: MFBT, task)

Description

[Eric Rahm [:erahm]]

+++ This bug was initially created as a clone of Bug #1145056 +++

As a follow up to bug 1145056 it would be nice to properly use |mozPoisonValue| [1] in GuardObjectNotifier [2] rather than #defining |MOZ_POISON|.

This cannot be done until we fix build errors related to how mfbt is linked (or not) for various targets on various platforms. I will file blocking bugs for each identified build issue.

[1] https://hg.mozilla.org/mozilla-central/annotate/4b9b12c248dc/mfbt/Poison.h#l27
[2] https://hg.mozilla.org/mozilla-central/annotate/4b9b12c248dc/mfbt/GuardObjects.h#l71

Comment 1

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afeb15d94e60

Comment 2

[Eric Rahm [:erahm]]

W/ poison.cpp added to DMD:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75a9fd14670e

There still seem to be mozglue related linking failures on Windows and Android.

Windows:
> LINK : fatal error LNK1194: cannot delay-load 'mozglue.dll' due to import of data symbol '__imp__gMozillaPoisonValue'; link without /DELAYLOAD:mozglue.dll

Android:
> /builds/slave/try-and-api-9-d-00000000000000/build/src/mozglue/linker/ElfLoader.cpp:845: error: undefined reference to 'gMozillaPoisonValue'
> ../../dist/include/mozilla/GuardObjects.h:98: error: undefined reference to 'gMozillaPoisonValue'
> /builds/slave/try-and-api-9-d-00000000000000/build/src/mozglue/linker/Zip.cpp:42: error: undefined reference to 'gMozillaPoisonValue'

Comment 3

[Eric Rahm [:erahm]]

glandium suggested that if we only using |mozPoisonValue| in libxul builds we can avoid the build failures. This seems good enough to me.

Comment 4

[Eric Rahm [:erahm]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b44bfd55bdb

Comment 5

[Eric Rahm [:erahm]]

Attachment: Use mozilla/Poison.h in GuardObjectNotifier

Comment 6

[Eric Rahm [:erahm]]

(See comment 4)

Comment 7

[Eric Rahm [:erahm]]

(In reply to Eric Rahm [:erahm] from comment #6)
> (See comment 4)

Oh right, we need to land bug 1160272 first.

Comment 8

[Eric Rahm [:erahm]]

Nathan's removing GuardObjectNotifier usage in bug 1223932, I'm going to abandon this.