Closed
Bug 1160263
Opened 9 years ago
Closed 9 years ago
Don't allow add-ons to override the periodic XPI signature check
Categories
(Toolkit :: Application Update, defect)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mossop, Unassigned)
References
Details
Attachments
(1 file)
1.07 KB,
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Part of the new signing requirements involve a background timer to periodically check that all add-ons are still correctly signed. The update timer is good as a regular sloppy timer and I don't want to rewrite that however at the moment it is trivial to override a timer to stop the real one from happening. This patch works around it by checking any attempted re-registration of a time to a different callback and rejects them. This passes all tests though we might want to add a check for this case specifically but wanted to get review on this piece first.
Attachment #8600011 -
Flags: review?(robert.strong.bugs)
Updated•9 years ago
|
Attachment #8600011 -
Flags: review?(robert.strong.bugs) → review+
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e1d5dc5393f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•