DMD build should include |mfbt/Poison.cpp|

RESOLVED FIXED in Firefox 45

Status

()

Core
DMD
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

(Blocks: 1 bug)

Trunk
mozilla45
Points:
---

Firefox Tracking Flags

(firefox40 affected, firefox45 fixed)

Details

Attachments

(1 attachment)

In bug 1160253 we would like to use |mozPoisonValue()| in |GuardObjectNotifier|. This breaks the DMD build due to a missing symbol.

glandium suggests just including |Poison.cpp| rather than the entire mfbt lib as that would probably break the windows build.
Created attachment 8600103 [details] [diff] [review]
DMD build should include |mfbt/Poison.cpp|
Attachment #8600103 - Flags: review?(mh+mozilla)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Comment on attachment 8600103 [details] [diff] [review]
DMD build should include |mfbt/Poison.cpp|

Review of attachment 8600103 [details] [diff] [review]:
-----------------------------------------------------------------

This is not required in itself. It should just be part of the patch for bug 1160253
Attachment #8600103 - Flags: review?(mh+mozilla) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3c4b8af894f2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.