1160278 - Many SpiderMonkey compilation units are sensitive to unified compilation

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Nicolas B. Pierron [:nbp]]

+++ This bug was initially created as a clone of Bug #1155006 +++

Disabling unified builds in js/src causes many build failures, which means that different unification groupings will also fail.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Fix non-unified build in js/src.

Comment 2

[Sean Stangl [:sstangl]]

I'm building the ARM64 branch without unified compilation, and a merge from master breaks the build about twice a week, usually from missing headers. Is there some plausible way we could occasionally build without unification on to catch these errors as they crop up? Otherwise it looks like we'll be seeing a lot more of this bug.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Dropping non-unified builds in production was a conscious decision. We used to run them.

Comment 4

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8600037 [details] [diff] [review]
Fix non-unified build in js/src.

Changing reviewer based on comment 2.

Comment 5

[Sean Stangl [:sstangl]]

Comment on attachment 8600037 [details] [diff] [review]
Fix non-unified build in js/src.

Review of attachment 8600037 [details] [diff] [review]:
-----------------------------------------------------------------

Oh gosh, this is old! Sorry for not noticing it until now!

I don't know whether the patch is still relevant, but the changes look plausible. Make sure to run the check-style script before checking in.

::: js/src/jit/Ion.cpp
@@ +48,5 @@
>  #include "jsobjinlines.h"
> +#include "jsscriptinlines.h"
> +
> +#include "jit/JitFrames-inl.h"
> +#include "vm/ScopeObject-inl.h"

This will break #include ordering, right? Run "make check-style" or "make style-check" or whatever we're calling it these days.

Comment 6

[Nicolas B. Pierron [:nbp]]

Unfortunately, after a rebase, I noticed that most of the modification I made got applied in a different way by different patches.