[Text Selection][Browser] Text selection does not work properly on TOP SITES titles

VERIFIED FIXED in Firefox OS master

Status

VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: ychung, Assigned: TYLin)

Tracking

unspecified
FxOS-S5 (21Aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(b2g-v2.2 affected, b2g-master verified)

Details

(Whiteboard: [3.0-Daily-Testing], URL)

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8600067 [details]
logcat_TextSelectionError.txt

Description:
When the user long-presses a section on a title of a top site thumbnail, wrong section is selected (a word to the left of the selected section, or a word in a different thumbnail). The carets do not move properly as well.

Pre-requisite: Have a few websites visited previously on Browser.

Repro Steps:
1) Update a Flame to 20150430010201.
2) Open Browser.
3) Select a section on a title under TOP SITES.
4) Move around the carets.

Actual:
3) A wrong section is highlighted. Usually it's a word to the left of the word that the user originally long-pressed, or sometimes a word on a different thumbnail is selected.
4) The carets do not move properly as the user moves them around.

Expected:
3) The selected word is highlighted properly.
4) The carets move around properly as the user moves them.

Environmental Variables:
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150430010201
Gaia: db8ea705c0fd1b1684807f5a8e837bb9a36a6f96
Gecko: 4b9b12c248dc
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 5/5
See attached: Video, logcat
https://youtu.be/28tdra4Pjj8
(Reporter)

Comment 1

3 years ago
This issue also reproduces on Flame 2.2.

Result: Text selection does not work properly on TOP SITES titles.

Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150430002504
Gaia: aa1da5036f9425c25d515d14243d3473bfefb4fd
Gecko: 38b2838d43e1
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?][COM=Text Selection]
Flags: needinfo?(ktucker)
Component: Gaia::System::Browser Chrome → Selection
Product: Firefox OS → Core
I don't think copy and paste should work on thumbnails. Gerry, can you take a look at this please?
QA Whiteboard: [QAnalyst-Triage?][COM=Text Selection] → [QAnalyst-Triage+][COM=Text Selection]
Flags: needinfo?(ktucker) → needinfo?(gchang)
Hi Omega,
Can you help on this? Not sure if copy/paste feature should be enabled on the top site thumbnails.
Flags: needinfo?(gchang) → needinfo?(ofeng)
I don't think text selection should be enabled in this page. Let's turn it off.
Flags: needinfo?(ofeng)
Add developer in CC.
Created attachment 8646363 [details] [review]
[gaia] aethanyc:bug1160299 > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8646363 - Flags: review?(dale)
(Assignee)

Updated

3 years ago
Assignee: nobody → tlin
Comment on attachment 8646363 [details] [review]
[gaia] aethanyc:bug1160299 > mozilla-b2g:master

This looks good, thanks
Attachment #8646363 - Flags: review?(dale) → review+
(Assignee)

Updated

3 years ago
Component: Selection → Gaia::System::Browser Chrome
Product: Core → Firefox OS
(Assignee)

Comment 8

3 years ago
Dale, thank you for the review.
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Blocks: 1128421
No longer blocks: 1023688
Master: https://github.com/mozilla-b2g/gaia/commit/29bb66be5ec120e25202964ef75b2234c0c8f562
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S5 (21Aug)
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Text selection is disabled and unavailable on TOP SITES titles as expected.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150813150207
Gaia Revision          acfaa3957e65d52a0af2185149628a520edcc7e2
Gaia Date              2015-08-13 12:34:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cdf53a4dee219aabec7462888875bac08b093edc
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150813.184539
Firmware Date          Thu Aug 13 18:45:52 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150814002719
Gaia Revision          39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gaia Date              2015-08-13 18:25:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150813.235024
Firmware Date          Thu Aug 13 23:50:32 UTC 2015
Bootloader             s1
QA Whiteboard: [QAnalyst-Triage+][COM=Text Selection] → [QAnalyst-Triage+][COM=Text Selection][MGSEI-Triage+]
status-b2g-master: fixed → verified
Created attachment 8647880 [details]
verified_FlameKK_v2.5.3gp
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.