Closed
Bug 1160313
Opened 9 years ago
Closed 9 years ago
Reenabling all non-profiler components for 40.1
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
(Whiteboard: [polish-backlog])
Attachments
(1 file)
12.67 KB,
patch
|
vporof
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Will land after bug 1156499 makes its way to 40.0
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Blocks: perf-tool-v2
Status: NEW → ASSIGNED
Depends on: 1156499
Priority: -- → P1
Assignee | ||
Comment 1•9 years ago
|
||
goodbye retro mode https://treeherder.mozilla.org/#/jobs?repo=try&revision=01571de5c5c7
Attachment #8606414 -
Flags: review?(vporof)
Comment 2•9 years ago
|
||
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Review of attachment 8606414 [details] [diff] [review]: ----------------------------------------------------------------- This makes me so happy
Attachment #8606414 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/06ced37f6c2b
Whiteboard: [fixed-in-fx-team][devedition-40]
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/06ced37f6c2b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][devedition-40] → [devedition-40]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Blocks: perf-40-uplifts
Updated•9 years ago
|
Flags: qe-verify+
Comment 5•9 years ago
|
||
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8606414 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a19453eac6e3
status-firefox40:
--- → fixed
Comment 7•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 8•9 years ago
|
||
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Change approved to skip one train as part of the spring campaign.
Attachment #8606414 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•9 years ago
|
||
It was my understanding that this bug should enable back the new Performance features on Aurora 40, perhaps because there won't be a 40.1? Jordan - please correct me if I'm wrong. This is verified fixed on Aurora 40.0a2 (2015-06-09), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. The detail views, overview graph, marker filter button, memory graph, profiler options and the timeline tool are all enabled.
Status: RESOLVED → VERIFIED
Flags: qe-verify+ → needinfo?(jsantell)
Assignee | ||
Comment 10•9 years ago
|
||
That is all correct, 40.1 shipped to aurora on June 2nd (I guess the version increment didn't actually happen, looks like it's still 40.0a2), so I guess that was just for planning purposes, but everything sounds right
Flags: needinfo?(jsantell)
Updated•9 years ago
|
Whiteboard: [devedition-40] → [polish-backlog]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•