Closed Bug 1160313 Opened 5 years ago Closed 5 years ago
Reenabling all non-profiler components for 40
Will land after bug 1156499 makes its way to 40.0
goodbye retro mode https://treeherder.mozilla.org/#/jobs?repo=try&revision=01571de5c5c7
Attachment #8606414 - Flags: review?(vporof)
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Review of attachment 8606414 [details] [diff] [review]: ----------------------------------------------------------------- This makes me so happy
Attachment #8606414 - Flags: review?(vporof) → review+
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8606414 - Flags: approval-mozilla-aurora?
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8606414 [details] [diff] [review] 1160313-remove-retro.patch Change approved to skip one train as part of the spring campaign.
Attachment #8606414 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
It was my understanding that this bug should enable back the new Performance features on Aurora 40, perhaps because there won't be a 40.1? Jordan - please correct me if I'm wrong. This is verified fixed on Aurora 40.0a2 (2015-06-09), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. The detail views, overview graph, marker filter button, memory graph, profiler options and the timeline tool are all enabled.
That is all correct, 40.1 shipped to aurora on June 2nd (I guess the version increment didn't actually happen, looks like it's still 40.0a2), so I guess that was just for planning purposes, but everything sounds right
Whiteboard: [devedition-40] → [polish-backlog]
You need to log in before you can comment on or make changes to this bug.