Closed
Bug 1160324
Opened 9 years ago
Closed 9 years ago
Handle missing robocopApk files in runtestsremote.py
Categories
(Firefox for Android Graveyard :: Testing, defect)
Firefox for Android Graveyard
Testing
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
Details
Attachments
(1 file, 1 obsolete file)
Right now, a specified-but-missing robocopApk file turns into a random-looking symbol not found error in runtestsremote.py. This happens because options is set to None (on error) at [1], but interrogated at [2], before error checking at [3]. This took some debugging to trace down -- let's fix it for the good of local testers, at least. [1] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#493 [2] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#495 [3] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#501
Assignee | ||
Comment 1•9 years ago
|
||
/r/7961 - Bug 1160324 - Handle missing robocopApk files in runtestsremote.py. r=gbrown Pull down this commit: hg pull -r 7d8043298e133ab903b55ba9c8530b2ea28a3180 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8600089 -
Flags: review?(gbrown)
Comment 2•9 years ago
|
||
Comment on attachment 8600089 [details] MozReview Request: bz://1160324/nalexander https://reviewboard.mozilla.org/r/7959/#review6755
Attachment #8600089 -
Flags: review?(gbrown) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/380fcf2381b5
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/380fcf2381b5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8600089 -
Attachment is obsolete: true
Attachment #8620207 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•