1160324 - Handle missing robocopApk files in runtestsremote.py

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Nick Alexander :nalexander [he/him]]

Right now, a specified-but-missing robocopApk file turns into a random-looking symbol not found error in runtestsremote.py.  This happens because options is set to None (on error) at [1], but interrogated at [2], before error checking at [3].

This took some debugging to trace down -- let's fix it for the good of local testers, at least.

[1] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#493

[2] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#495

[3] https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtestsremote.py#501

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: bz://1160324/nalexander

/r/7961 - Bug 1160324 - Handle missing robocopApk files in runtestsremote.py. r=gbrown

Pull down this commit:

hg pull -r 7d8043298e133ab903b55ba9c8530b2ea28a3180 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 8600089 [details]
MozReview Request: bz://1160324/nalexander

https://reviewboard.mozilla.org/r/7959/#review6755

Comment 3

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/380fcf2381b5

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/380fcf2381b5

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1160324 - Handle missing robocopApk files in runtestsremote.py. r=gbrown