Closed
Bug 1160332
Opened 9 years ago
Closed 9 years ago
Reselecting with calltree in view results in choppy rerendering
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
6.91 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
Suspect a lazy debounce or lazy rendering of the calltree will fix this. Gif: http://i.imgur.com/zR2eAVJ.gif This is important because in 40.0, we will ONLY have the js-calltree with the framerate graph.
Comment 1•9 years ago
|
||
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #0) > Suspect a lazy debounce or lazy rendering of the calltree will fix this. > Gif: http://i.imgur.com/zR2eAVJ.gif > We already have a debounce, but it's probably not enough. Also, Nick's new `shouldUpdateWhileMouseIsActive` from bug 1157914 should help a lot.
Updated•9 years ago
|
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee | ||
Comment 2•9 years ago
|
||
In the bugzilla flurry, did not realize you grabbed this, victor. It looks like the patch in bug 1157914 was never rebased after the GraphsController landed, so it didn't actually work. This goes on top of it, fixing the jank for non flamegraph details views https://treeherder.mozilla.org/#/jobs?repo=try&revision=766243eb6833
Assignee: vporof → jsantell
Attachment #8600190 -
Flags: review?(vporof)
Comment 3•9 years ago
|
||
Comment on attachment 8600190 [details] [diff] [review] 1160332-mouseactive.patch Review of attachment 8600190 [details] [diff] [review]: ----------------------------------------------------------------- comments ::: browser/devtools/performance/modules/graphs.js @@ +328,5 @@ > /** > + * Returns an array of graphs that have been created, not necessarily > + * enabled currently. > + */ > + getGraphs: function () { getWidgets() is probably better. graphs.getGraphs() is weird as hell. ::: browser/devtools/performance/views/overview.js @@ +99,5 @@ > get isMouseActive() { > + // Fetch all graphs currently stored in the GraphsController. > + // These graphs are not necessarily active, but will not have > + // an active mouse, in that case. > + for (let graph of this.graphs.getGraphs()) { return !!this.graphs.getGraphs().find(e => e.isMouseActive); is nicer.
Attachment #8600190 -
Flags: review?(vporof) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8600190 [details] [diff] [review] 1160332-mouseactive.patch Review of attachment 8600190 [details] [diff] [review]: ----------------------------------------------------------------- Actually, I'd love to see a small test for this.
Attachment #8600190 -
Flags: review+ → feedback+
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=999a76f1b86b
Attachment #8600190 -
Attachment is obsolete: true
Attachment #8600221 -
Flags: review?(vporof)
Updated•9 years ago
|
Attachment #8600221 -
Flags: review?(vporof) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/14c8c3fd403c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•