1160337 - GCF TC 31.4.3.4 : Terminate held multiparty call failed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[pgravel]

Test is from 3GPP TS 51.010, section 31.4.3.4
This test checks that the phone correctly terminates a held MultiParty call by initiating call clearance for each party in turn.

Scenario for TC 31.4.3.4:
1.	Phone has held multiparty call
2.	Pressing END call button should disconnect both calls, but it currently only disconnects only a single call. 

This is due to bug in calls_handler end() function where it only calls endConferenceCall() if conference is active, whereas in this scenario the conference is on hold.

Comment 1

[Keven Kuo [:kkuo]]

Hi! Sean,

Have you fixed this before?

--
Keven

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Hi Keven, Sorry that I have not fixed this before.

Comment 3

[shawn ku [:sku]]

I don't think there is a "end all call" behavior by single gaia action.
Unless there is a UI to end all calls, this test case can not get passed.

Comment 4

[Johan Lorenzo [:jlorenzo]]

I can't reproduce on 2.2 [1]. Here are the steps I followed:

1. From the device under test, call another device.
2. Once the call is established, from the device under test, call the voicemail
3. Merge the 2 calls.
4. Once the calls are properly merged, press the "end call" button => Each call is hung up. 

[1] Build ID               20150503162504
Gaia Revision          8d14361337e608c8cdf165ea5034db5eda23b618
Gaia Date              2015-05-01 18:23:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/cb7cb6597c91
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150503.200206
Firmware Date          Sun May  3 20:02:17 EDT 2015
Bootloader             L1TC000118D0

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #4)
> 4. Once the calls are properly merged, press the "end call" button => Each
> call is hung up. 
And I forgot a step: Once the calls are properly merged, put these calls on hold.
5. Press the "end call" button => Each call is hung up.

Comment 6

[Gabriele Svelto [:gsvelto] (PTO)]

What I see is that we terminate one of the calls in the group and this causes the conference to be ended too. I'm not sure if we can rely on this though so I'll prepare a patch to properly hang up the conference group instead of one of its calls.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1160337-end-held-conference-group > mozilla-b2g:master

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

Comment on attachment 8600887 [details] [review]
[gaia] gabrielesvelto:bug-1160337-end-held-conference-group > mozilla-b2g:master

Quick fix for the problem with unit-tests added. I've tried to make the whole procedure more robust rather than having it work happenchance.

Comment 9

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8600887 [details] [review]
[gaia] gabrielesvelto:bug-1160337-end-held-conference-group > mozilla-b2g:master

Looks good, thanks.

Comment 10

[Gabriele Svelto [:gsvelto] (PTO)]

Thanks for the review, ready to land.

Comment 11

[Gabriele Svelto [:gsvelto] (PTO)]

Ooops, I missed the review comment on GitHub. I'll open a follow up if Autolander manages to land this.

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e934596ff9c1239c3aceb23301ba641cb8e76cab

Comment 13

[Anshul]

Comment on attachment 8600887 [details] [review]
[gaia] gabrielesvelto:bug-1160337-end-held-conference-group > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 14

[Johan Lorenzo [:jlorenzo]]

Comms triage: Certification blocker on a new feature added in 2.2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c6a6996841860ab335bf46b273477dc4bef19c95