Closed Bug 1160348 Opened 9 years ago Closed 9 years ago

[Usage][cost control][text selection] A result of 'NaN' becomes entered into the Data Usage Limit text box and can not be erased when selecting the 'paste' option

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)

VERIFIED FIXED
2.2 S12 (15may)
blocking-b2g 2.2+
Tracking Status
b2g-v2.2 --- verified
b2g-master --- verified

People

(Reporter: jmitchell, Assigned: salva)

References

()

Details

(Whiteboard: [3.0-Daily-Testing])

Attachments

(3 files)

Description:
When setting the data usage limit in the Usage app, if the user hits the 'paste' text selection function without having already cut or copied a numeric value, a result of NaN will appear in the text box. This result can not be deleted with the Backspace button, nor can any other numbers be entered into the text box. 


Repro Steps:
1) Update a Flame to 20150430010201
2) Launch Usage app
3) Set data usage limit
4) When offered the text box to enter a value for the alert to occur, long press to receive text selection options and then select paste


Actual:
NaN becomes entered into text box


Expected:
Paste function will not be available unless numeric value has been cut or copied



Environmental Variables:
Device: Flame 3.0
Build ID: 20150430010201
Gaia: db8ea705c0fd1b1684807f5a8e837bb9a36a6f96
Gecko: 4b9b12c248dc
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0




Repro frequency: 7/7
See attached: logcat video clip: http://youtu.be/r3V95rETB0E
This issue also reproduces in Flame KK 2.2; text selection is not supported prior to that

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150429002501
Gaia: 1b7aa7e60788668ed09abf76022dfa231dbe88d4
Gecko: d38ff4717f39
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?][COM=Text Selection]
Flags: needinfo?(pbylenga)
Broken functionality of a new feature. NI component owner for tracking.
blocking-b2g: --- → 2.2?
QA Whiteboard: [QAnalyst-Triage?][COM=Text Selection] → [QAnalyst-Triage+][COM=Text Selection]
Flags: needinfo?(pbylenga) → needinfo?(slyu)
triage: major issue on text selection. should be fixed.
blocking-b2g: 2.2? → 2.2+
Flags: needinfo?(noemi.freiredecarlos)
Hi Noemi,
Could you find someone to look into this?
(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #4)
> Hi Noemi,
> Could you find someone to look into this?

Salva will check it.
Flags: needinfo?(noemi.freiredecarlos)
Assignee: nobody → salva
If no text has been copied or selected before, paste functionality simply does not appear but if you have selected some text (not a number), then you paste it, it will display the NaN. Let me check how to avoid this.
Comment on attachment 8601089 [details] [review]
[gaia] lodr:bug-1160348-nan-on-paste > mozilla-b2g:master

Adding a missed type conversion.
Attachment #8601089 - Flags: review?(marina.rodrigueziglesias)
Notice this patch does not avoid to paste incorrect values (which is something a lot more complicated as no onpaset event exists) but, at least, allow the user to delete the incorrect value in order to enter a proper one.
Comment on attachment 8601089 [details] [review]
[gaia] lodr:bug-1160348-nan-on-paste > mozilla-b2g:master

Hi Salva, 
the patch Works as you mentioned, I cannot produce now a NaN. Thanks for your work!
Regards
Attachment #8601089 - Flags: review?(marina.rodrigueziglesias) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S12 (15may)
This issue is verified fixed on Flame 3.0. Note that the fixed behavior is NOT the expected behavior on comment 0, instead it is the behavior mentioned in comment 9.

The problematic field still accepts non-numeric text to be pasted, but it is now deletable and it doesn't paste an irrelevant NaN.

Device: Flame 3.0
BuildID: 20150506010204
Gaia: 3e6fd1e0a478af2c95d09ce95c2c6de2de2fec14
Gecko: ba44099cbd07
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Adding verifyme tag for v2.2 verification after uplift.
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][COM=Text Selection] → [QAnalyst-Triage?][COM=Text Selection]
Flags: needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?][COM=Text Selection] → [QAnalyst-Triage+][COM=Text Selection]
Flags: needinfo?(ktucker)
Flags: needinfo?(slyu)
Please request Gaia v2.2 approval on this patch when you get a chance.
Flags: needinfo?(salva)
Comment on attachment 8601089 [details] [review]
[gaia] lodr:bug-1160348-nan-on-paste > mozilla-b2g:master

[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: hight, non recoverable unless restarting application.
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none
Flags: needinfo?(salva)
Attachment #8601089 - Flags: approval-gaia-v2.2?
Comment on attachment 8601089 [details] [review]
[gaia] lodr:bug-1160348-nan-on-paste > mozilla-b2g:master

Approving and QA please verify on 2.2 after patch landed.
Attachment #8601089 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Attached video 0447.mp4
According to comment9,this issue is verified pass on Flame v2.2 and Nexus5 v2.2. 
Actual results: When there's no content in pasteboard, if we long press the input box, the paste icon will not display in edit toolbar; When user has copied some non-numeric text in pasteboard, the non-numeric text can be pasted in input box and user can delete the text normally.
See attachment: 0447.mp4
Reproduce rate: 0/6

Device: Flame 2.2 build(Pass)
Build ID               20150531162502
Gaia Revision          b4582cc394e0919623263997c0cdb0b4751a1403
Gaia Date              2015-05-31 11:06:34
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/78d8b0a4303d
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150531.195816
Firmware Date          Sun May 31 19:58:28 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 2.2 build(Pass) 
Build ID               20150531002502
Gaia Revision          0a46394dbee0ed2eb71a136cee38ddd8549dd597
Gaia Date              2015-05-30 14:50:16
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ed2f6aeb1d81
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150531.043812
Firmware Date          Sun May 31 04:38:27 EDT 2015
Bootloader             HHZ12f
QA Whiteboard: [QAnalyst-Triage+][COM=Text Selection] → [QAnalyst-Triage+][COM=Text Selection] [MGSEI-Triage+]
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: