Closed Bug 1160371 Opened 5 years ago Closed 4 years ago

Intermittent test_oauth_tokens.js | Test timed out

Categories

(Cloud Services :: Server: Firefox Accounts, defect)

defect
Not set

Tracking

(firefox38 unaffected, firefox38.0.5 unaffected, firefox39 fixed, firefox40 fixed, firefox43 fixed, firefox-esr31 unaffected, firefox-esr38 unaffected)

RESOLVED FIXED
mozilla40
Tracking Status
firefox38 --- unaffected
firefox38.0.5 --- unaffected
firefox39 --- fixed
firefox40 --- fixed
firefox43 --- fixed
firefox-esr31 --- unaffected
firefox-esr38 --- unaffected

People

(Reporter: KWierso, Assigned: markh)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

This started happening a few days ago, I think. Retriggers running to try tracking it down, but bug 1151666 is really spammy and making it hard to tell where it started. (Maybe they're the same cause?)

14:28:23 INFO - TEST-PASS | services/fxaccounts/tests/xpcshell/test_oauth_client.js | took 84603ms
14:28:27 INFO - TEST-START | services/fxaccounts/tests/xpcshell/test_oauth_grant_client.js
14:30:29 INFO - TEST-PASS | services/fxaccounts/tests/xpcshell/test_oauth_grant_client.js | took 122472ms
14:30:32 INFO - TEST-START | services/fxaccounts/tests/xpcshell/test_oauth_grant_client_server.js
14:32:28 INFO - TEST-PASS | services/fxaccounts/tests/xpcshell/test_oauth_grant_client_server.js | took 115362ms
14:32:31 INFO - TEST-START | services/fxaccounts/tests/xpcshell/test_oauth_tokens.js
14:37:31 WARNING - TEST-UNEXPECTED-TIMEOUT | services/fxaccounts/tests/xpcshell/test_oauth_tokens.js | Test timed out
14:37:31 INFO - TEST-INFO took 300039ms
14:37:32 INFO - xpcshell return code: -1
14:37:41 INFO - Exception in thread ProcessReader:
14:37:41 INFO - Traceback (most recent call last):
14:37:41 INFO - File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
14:37:41 INFO - self.run()
14:37:41 INFO - File "/usr/lib/python2.7/threading.py", line 504, in run
14:37:41 INFO - self.__target(*self.__args, **self.__kwargs)
14:37:41 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozprocess/processhandler.py", line 929, in _read
14:37:41 INFO - self.timeout_callback()
14:37:41 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozprocess/processhandler.py", line 840, in __call__
14:37:41 INFO - e(*args, **kwargs)
14:37:41 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/mozdevice/devicemanagerADB.py", line 138, in _raise
14:37:41 INFO - raise DMError("Timeout exceeded for shell call")
14:37:41 INFO - DMError: Timeout exceeded for shell call
14:37:42 INFO - services/fxaccounts/tests/xpcshell/test_oauth_tokens.js | Process still running after test!
14:37:42 INFO - >>>>>>>
This test arranges for mock storage to be used like test_accounts etc, and shows a marked improvement in test run times. Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3f7b740fa66
Attachment #8602561 - Flags: review?(zack.carter)
Comment on attachment 8602561 [details] [diff] [review]
0001-Bug-1160371-use-mock-storage-in-the-oauth-token-test.patch

Review of attachment 8602561 [details] [diff] [review]:
-----------------------------------------------------------------

Mock all the things.
Attachment #8602561 - Flags: review?(zack.carter) → review+
Assignee: nobody → markh
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/406c618c6cac
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
This was missed in a storage refactor, bring back the original symptoms. Patch upcoming.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The storage mocks we previously used were neutered by the recent storage refactor. This updates that test to use the new way of mocking storage.
Attachment #8646658 - Flags: review?(zack.carter)
Comment on attachment 8646658 [details] [diff] [review]
0001-Bug-1160371-fix-intermittent-test_oauth_tokens.js-by.patch

Review of attachment 8646658 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks mark
Attachment #8646658 - Flags: review?(zack.carter) → review+
https://hg.mozilla.org/mozilla-central/rev/a75f036fba84
Status: REOPENED → RESOLVED
Closed: 5 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.