1160374 - [Settings][Call Barring] Cancel and OK button not working on Enter passcode screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_CallBarringPasscodeError.txt

Description:
When the user toggles on any option on Call Barring menu screen, the passcode page appears. However, the user is stuck on this screen as Cancel and OK button do not function. The only way to get out of this screen is to force close from the card view.

Repro Steps:
1) Update a Flame to 20150430010201.
2) Open Settings > Call Settings > Call Barring.
3) When the network information is received, toggle on any option.
4) On the passcode screen, select cancel.
5) Enter any passcode, and select OK.

Actual:
4 & 5) The screen remains on the passcode screen and does not return to the previous page. 

Expected:
4 & 5) The user is returned to the previous screen (Call Barring menu screen).

Environmental Variables:
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150430010201
Gaia: db8ea705c0fd1b1684807f5a8e837bb9a36a6f96
Gecko: 4b9b12c248dc
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Repro frequency: 5/5
See attached: Video, logcat
https://youtu.be/I9KQBFjV-FA

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.2.

Result: The user can cancel out of the page, or enter the passcode and return to the previous screen.

Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150430002504
Gaia: aa1da5036f9425c25d515d14243d3473bfefb4fd
Gecko: 38b2838d43e1
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

From bug 1144410 comment 6 through 8, I've already tested that the regression here is a gaia regression rather than a gecko regression.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

Broken functionality so nominating this 3.0?

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Triage: 2.5+ as it's a broken basic feature

Comment 5

[Ken Chang[:kenkai]]

Hi Fred,can you take this bug?

Comment 6

[Evan Tseng [:evanxd]]

I would like to help this.

Comment 7

[[e-mail]]

Thanks Evan!

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] evanxd:bug-1160374 > mozilla-b2g:master

Comment 9

[Evan Tseng [:evanxd]]

Comment on attachment 8647397 [details] [review]
[gaia] evanxd:bug-1160374 > mozilla-b2g:master

Hi Fred,

Could you review this patch?

Thanks.

Comment 10

[[e-mail]]

Comment on attachment 8647397 [details] [review]
[gaia] evanxd:bug-1160374 > mozilla-b2g:master

thanks!

Comment 11

[Evan Tseng [:evanxd]]

master: https://github.com/mozilla-b2g/gaia/commit/acfaa3957e65d52a0af2185149628a520edcc7e2

Comment 12

[Evan Tseng [:evanxd]]

Fred, thanks for the review.

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The "OK" and "Cancel" button works well, and user can be returned to the previous screen (Call Barring menu screen) after tapping Cancel button.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150816150205
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.182145
Firmware Date          Sun Aug 16 18:21:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150816151853
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-
central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150816.144248
Firmware Date          Sun Aug 16 14:42:55 UTC 2015
Bootloader             s1

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp