Closed
Bug 1160393
Opened 9 years ago
Closed 9 years ago
Setup webrtc logging environment for android tests
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bwc, Assigned: gbrown)
References
Details
Attachments
(1 file)
1.61 KB,
patch
|
bwc
:
review+
|
Details | Diff | Splinter Review |
We need essentially the same environment set up here: https://dxr.mozilla.org/mozilla-central/source/build/automation.py.in#508
Assignee | ||
Comment 1•9 years ago
|
||
It is easy to set R_LOG_LEVEL, etc, but there is a problem with NSPR_LOG_MODULES on Android: Environment variables set in Android automation cannot contain commas. I can set NSPR_LOG_MODULES="all:5", but that would generate a ton of logging. Any one log tag would be fine also, but we can't do two or more. Bug 977589 has some history. Shall we go with this for now?
Attachment #8600439 -
Flags: review?(docfaraday)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8600439 [details] [diff] [review] enable WebRTC logging, except for NSPR_LOG_MODULES, on Android Review of attachment 8600439 [details] [diff] [review]: ----------------------------------------------------------------- This is at least a start, and provides a placeholder for setting up the logging subsystem you want on a given try push, so is better than nothing for nspr. (You can also now find this file by grepping for R_LOG_LEVEL, which is nice)
Attachment #8600439 -
Flags: review?(docfaraday) → review+
Reporter | ||
Comment 3•9 years ago
|
||
Should probably put the bug number in the patch above the commented-out NSPR_LOG_MODULES line, come to think of it.
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/91145ffa5774
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment 6•9 years ago
|
||
I think the patch broke mochitest-plain for local tests on Fennec. I tried running the command "mach mochitest-plain" on three different machines (combination of Mac and Linux) with 3 different phones and it fails to launch the browser on the device. I bisected the failure to this bug and after reverting the changes in the patch, I am able to run the tests again. gbrown: I am not familiar with this code, do you have any guesses why this would be happening?
Flags: needinfo?(gbrown)
Assignee | ||
Comment 7•9 years ago
|
||
:wchen -- I'm so sorry about that! I can't think of how this could be causing a failure. I can run "mach mochitest-plain" on Linux against an Android 4.0 Galaxy Nexus without any problem. I am running adb version 1.0.32; would you check "adb version" on your machines? Also I wonder if your logcat shows anything? Perhaps it would be best to open a new bug for your issue and cc or assign me to it.
Flags: needinfo?(gbrown)
You need to log in
before you can comment on or make changes to this bug.
Description
•