Closed Bug 1160422 Opened 6 years ago Closed 6 years ago

Prioritize size decodes over full decodes

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

The summary says it all, really. Size decodes (i.e., decoding of image headers) block layout and page load, while full decodes do not. So we should always prioritize size decodes.
Assignee: nobody → seth
Blocks: 1160423
Here's the patch. Pretty simple once we have the infrastructure from bug 1160421
in place. We put size decodes and full decodes in separate queues, and always
pop work from the size decode queue before we pop work from the full decode
queue.
Attachment #8603116 - Flags: review?(tnikkel)
Blocks: 1163856
Attachment #8603116 - Flags: review?(tnikkel) → review+
Thanks for the review!

Out of paranoia, I'll wait for one more try job before pushing, since the patch in bug 1160421 and I also want to double check that none of the failures in the try job in comment 2 are related to this patch.
OK, that try job looks good. This is ready to land. Inbound is closed, so requesting checkin.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c532ea31194f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.