1160422 - Prioritize size decodes over full decodes

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The summary says it all, really. Size decodes (i.e., decoding of image headers) block layout and page load, while full decodes do not. So we should always prioritize size decodes.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Prioritize size decodes over full decodes

Here's the patch. Pretty simple once we have the infrastructure from bug 1160421
in place. We put size decodes and full decodes in separate queues, and always
pop work from the size decode queue before we pop work from the full decode
queue.

Comment 2

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbec6d32b3de

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a8cdc718441

Comment 4

[Seth Fowler [:seth] [:s2h]]

Thanks for the review!

Out of paranoia, I'll wait for one more try job before pushing, since the patch in bug 1160421 and I also want to double check that none of the failures in the try job in comment 2 are related to this patch.

Comment 5

[Seth Fowler [:seth] [:s2h]]

OK, that try job looks good. This is ready to land. Inbound is closed, so requesting checkin.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c532ea31194f

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c532ea31194f